From: Steven Rostedt <rostedt@goodmis.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: John Stultz <john.stultz@linaro.org>,
Joel Fernandes <joelaf@google.com>,
lkml <linux-kernel@vger.kernel.org>,
Mark Salyzyn <salyzyn@android.com>,
Jonathan Corbet <corbet@lwn.net>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Christoffer Dall <cdall@linaro.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Olof Johansson <olof@lixom.net>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2 v8] printk: Add monotonic, boottime, and realtime timestamps
Date: Fri, 25 Aug 2017 10:58:14 -0400 [thread overview]
Message-ID: <20170825105814.3cf3ff50@gandalf.local.home> (raw)
In-Reply-To: <dac013d8-e70d-a89a-b2fb-d7651df983b0@redhat.com>
On Fri, 25 Aug 2017 10:46:21 -0400
Prarit Bhargava <prarit@redhat.com> wrote:
> np. I'm going to copy the code for
>
> u64 notrace ktime_get_boot_fast_ns(void)
>
> but I'm unsure why the function is marked "notrace", and if
> __ktime_get_real_fast_ns_unsafe() must be as well? I don't see anything in the
> git log that indicates why the function is notrace.
>
> I've added Joel to this thread ...
The "notrace" is added because it is one of the trace clocks:
kernel/trace/trace.c: { ktime_get_boot_fast_ns, "boot", 1 },
And function tracer can use it. We don't want to be tracing the clock
that the function tracer is using (otherwise it will get double
traced). It use to bug, but I believe I finally got the recursion
protection working to prevent that.
-- Steve
next prev parent reply other threads:[~2017-08-25 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 13:42 [PATCH 0/2 v8] printk: Add new timestamps Prarit Bhargava
2017-08-24 13:42 ` [PATCH 1/2 v8] time: Make fast functions return 0 before timekeeping is initialized Prarit Bhargava
2017-08-24 13:42 ` [PATCH 2/2 v8] printk: Add monotonic, boottime, and realtime timestamps Prarit Bhargava
2017-08-24 18:50 ` John Stultz
2017-08-25 14:46 ` Prarit Bhargava
2017-08-25 14:58 ` Steven Rostedt [this message]
2017-08-25 4:52 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825105814.3cf3ff50@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=cdall@linaro.org \
--cc=corbet@lwn.net \
--cc=deepa.kernel@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=john.stultz@linaro.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=olof@lixom.net \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=salyzyn@android.com \
--cc=sboyd@codeaurora.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®