From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-efi@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: Colin Ian King <colin.king@canonical.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt@codeblueprint.co.uk>
Subject: [PATCH 3/5] efi/reboot: Make function pointer orig_pm_power_off static
Date: Fri, 25 Aug 2017 16:50:17 +0100 [thread overview]
Message-ID: <20170825155019.6740-4-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20170825155019.6740-1-ard.biesheuvel@linaro.org>
From: Colin Ian King <colin.king@canonical.com>
The function pointer orig_pm_power_off is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'orig_pm_power_off' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
drivers/firmware/efi/reboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/reboot.c b/drivers/firmware/efi/reboot.c
index 7117e2d0c7f9..22874544d301 100644
--- a/drivers/firmware/efi/reboot.c
+++ b/drivers/firmware/efi/reboot.c
@@ -5,7 +5,7 @@
#include <linux/efi.h>
#include <linux/reboot.h>
-void (*orig_pm_power_off)(void);
+static void (*orig_pm_power_off)(void);
int efi_reboot_quirk_mode = -1;
--
2.11.0
next prev parent reply other threads:[~2017-08-25 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 15:50 [GIT PULL 0/5] more EFI changes for v4.14 Ard Biesheuvel
2017-08-25 15:50 ` [PATCH 1/5] efi/libstub: Enable reset attack mitigation Ard Biesheuvel
2017-08-26 7:58 ` [tip:efi/core] " tip-bot for Matthew Garrett
2017-08-25 15:50 ` [PATCH 2/5] efi/random: Increase size of firmware supplied randomness Ard Biesheuvel
2017-08-26 7:58 ` [tip:efi/core] " tip-bot for Ard Biesheuvel
2017-08-25 15:50 ` Ard Biesheuvel [this message]
2017-08-26 7:58 ` [tip:efi/core] efi/reboot: Make function pointer orig_pm_power_off static tip-bot for Colin Ian King
2017-08-25 15:50 ` [PATCH 4/5] efi: move efi_mem_type() to common code Ard Biesheuvel
2017-08-26 7:59 ` [tip:efi/core] efi: Move " tip-bot for Jan Beulich
2017-08-25 15:50 ` [PATCH 5/5] efi: bgrt: use efi_mem_type() Ard Biesheuvel
2017-08-26 7:59 ` [tip:efi/core] efi/bgrt: Use efi_mem_type() tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825155019.6740-4-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=colin.king@canonical.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®