[PATCH 0/3] arm64: dts: Initial ProBox2 Ava support

[PATCH 0/3] arm64: dts: Initial ProBox2 Ava support

[Andreas Färber]

Hello,

This mini-series adds a Device Tree for the PROBOX2 AVA Android TV Box.

Unlike the Zidoo X9S, serial (loady) was the only working way to boot a new
kernel from the vendor's U-Boot on this TV Box.
PROBOX2 support has been informed about bootloader issues with Ethernet, USB
and FAT on SD; the same symptoms have since been observed on the Lake I, so
be warned that those bugs might inconvenience other RTD1295 devices, too.

More details at:
https://en.opensuse.org/HCL:ProBox2_Ava

@PROBOX2: Please review the following three patches and either signal your
acknowledgement of my naming with an "Acked-by: name <email>" line or point
out any changes you would like to see applied (e.g., company name). Thanks!

Latest experimental patches at:
https://github.com/afaerber/linux/commits/rtd1295-next

Have a lot of fun!

Cheers,
Andreas

Cc: support@probox2.com
Cc: devicetree@vger.kernel.org

Cc: Wangchanchan <wangcc@azw-online.com>
Cc: beelinkservice@bee-link.com

Andreas Färber (3):
  dt-bindings: Add vendor prefix for ProBox2
  dt-bindings: arm: realtek: Add ProBox2 AVA
  arm64: dts: realtek: Add ProBox2 Ava

 Documentation/devicetree/bindings/arm/realtek.txt  |  1 +
 .../devicetree/bindings/vendor-prefixes.txt        |  1 +
 arch/arm64/boot/dts/realtek/Makefile               |  1 +
 .../arm64/boot/dts/realtek/rtd1295-probox2-ava.dts | 31 ++++++++++++++++++++++
 arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts  |  6 -----
 arch/arm64/boot/dts/realtek/rtd1295.dtsi           |  6 +++++
 6 files changed, 40 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm64/boot/dts/realtek/rtd1295-probox2-ava.dts

-- 
2.12.3

[PATCH 1/3] dt-bindings: Add vendor prefix for ProBox2

[Andreas Färber]

PROBOX2 is a Hong Kong based manufacturer of TV boxes.

Cc: support@probox2.com
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 I did not find a fully spelled out company name for this brand.
 
 http://probox2.com/contact-us/
 https://www.facebook.com/pg/probox2/about/
 
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 37867c3cb94b..683b1693078f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -261,6 +261,7 @@ plathome	Plat'Home Co., Ltd.
 plda	PLDA
 poslab	Poslab Technology Co., Ltd.
 powervr	PowerVR (deprecated, use img)
+probox2	PROBOX2
 pulsedlight	PulsedLight, Inc
 qca	Qualcomm Atheros, Inc.
 qcom	Qualcomm Technologies, Inc
-- 
2.12.3

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for ProBox2

[Rob Herring]

On Sun, Aug 27, 2017 at 02:54:23PM +0200, Andreas Färber wrote:
> PROBOX2 is a Hong Kong based manufacturer of TV boxes.
> 
> Cc: support@probox2.com
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  I did not find a fully spelled out company name for this brand.
>  
>  http://probox2.com/contact-us/
>  https://www.facebook.com/pg/probox2/about/
>  
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for ProBox2

[Andreas Färber]

Hi Wilson,

Please note that HTML-format mails are not permitted on most Linux
mailing lists, so your below message did not arrive for the other reviewers.

Am 01.09.2017 um 04:11 schrieb PROBOX2-CS:
> Hi Rob,
> 
> For the company of the brand is W2COMP COMPANY LIMITED or you can write
> PROBOX2.

My updated proposal is:

probox2         PROBOX2 (by W2COMP Co., Ltd.)

Rationale: Repeating the same name with just different casing on the
right does not provide additional information to a reader wondering whom
this prefix belongs to and whether to use it for new compatible strings.

If that proposal is okay with you, we still need to figure out how to
describe your company in the commit message below.

> thanks,
> Wilson
> PROBOX2
> 
> On Fri, Sep 1, 2017 at 5:14 AM, Rob Herring <robh@kernel.org
> <mailto:robh@kernel.org>> wrote:
> 
>     On Sun, Aug 27, 2017 at 02:54:23PM +0200, Andreas Färber wrote:
>     > PROBOX2 is a Hong Kong based manufacturer of TV boxes.

W2COMP describes itself as an "online reseller", and PROBOX2 does not
have any About Us page to derive a fair description from - "reseller"
appears to contradict my above description as "manufacturer".
Therefore my (unanswered) off-list inquiry from Aug 28, when you first
mentioned W2COMP to me.

So what about: "PROBOX2 is a TV box brand by Hong Kong based online
reseller W2COMP Company Limited."?

CC'ing William.

Thanks,
Andreas


>     >
>     > Cc: support@probox2.com <mailto:support@probox2.com>
>     > Signed-off-by: Andreas Färber <afaerber@suse.de
>     <mailto:afaerber@suse.de>>
>     > ---
>     >  I did not find a fully spelled out company name for this brand.
>     >
>     >  http://probox2.com/contact-us/
>     >  https://www.facebook.com/pg/probox2/about/
>     <https://www.facebook.com/pg/probox2/about/>
>     >
>     >  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>     >  1 file changed, 1 insertion(+)
> 
>     Acked-by: Rob Herring <robh@kernel.org <mailto:robh@kernel.org>>

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

[PATCH v2 1/3] dt-bindings: Add vendor prefix for ProBox2

[Andreas Färber]

PROBOX2 is a TV box brand by Hong Kong based online reseller W2COMP
Company Limited.

Cc: support@probox2.com
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v1 -> v2:
 * Extend the vendor prefix explanation with info provided by PROBOX2
 * Fix the commit message accordingly
 
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 9d1a48ba2445..6c6002cf6be6 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -264,6 +264,7 @@ plathome	Plat'Home Co., Ltd.
 plda	PLDA
 poslab	Poslab Technology Co., Ltd.
 powervr	PowerVR (deprecated, use img)
+probox2	PROBOX2 (by W2COMP Co., Ltd.)
 pulsedlight	PulsedLight, Inc
 qca	Qualcomm Atheros, Inc.
 qcom	Qualcomm Technologies, Inc
-- 
2.13.5

Re: [PATCH v2 1/3] dt-bindings: Add vendor prefix for ProBox2

[Andreas Färber]

Am 19.09.2017 um 23:54 schrieb Andreas Färber:
> PROBOX2 is a TV box brand by Hong Kong based online reseller W2COMP
> Company Limited.
> 
> Cc: support@probox2.com
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v1 -> v2:
>  * Extend the vendor prefix explanation with info provided by PROBOX2
>  * Fix the commit message accordingly

No objections to the v2 texts, so full series applied:

https://git.kernel.org/pub/scm/linux/kernel/git/afaerber/linux-realtek.git/log/?h=v4.15/dt64

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

[PATCH 2/3] dt-bindings: arm: realtek: Add ProBox2 AVA

[Andreas Färber]

Document a compatible string for the PROBOX2 AVA TV Box.

Cc: support@probox2.com
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 Documentation/devicetree/bindings/arm/realtek.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/realtek.txt b/Documentation/devicetree/bindings/arm/realtek.txt
index 13d755787b4f..297c15eb81e2 100644
--- a/Documentation/devicetree/bindings/arm/realtek.txt
+++ b/Documentation/devicetree/bindings/arm/realtek.txt
@@ -12,6 +12,7 @@ Required root node properties:
 
 Root node property compatible must contain, depending on board:
 
+ - ProBox2 AVA: "probox2,ava"
  - Zidoo X9S: "zidoo,x9s"
 
 
-- 
2.12.3

Re: [PATCH 2/3] dt-bindings: arm: realtek: Add ProBox2 AVA

[Rob Herring]

On Sun, Aug 27, 2017 at 02:54:24PM +0200, Andreas Färber wrote:
> Document a compatible string for the PROBOX2 AVA TV Box.
> 
> Cc: support@probox2.com
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  Documentation/devicetree/bindings/arm/realtek.txt | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 3/3] arm64: dts: realtek: Add ProBox2 Ava

[Andreas Färber]

Add a Device Tree for the PROBOX2 AVA TV Box.
Move common memory reservations into rtd1295.dtsi.

Cc: support@probox2.com
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 I've been torn on whether this should be just rtd1295-ava.dts?
 The vendor is indicated in the compatible string and model property.
 rtd1295-x9s.dts hadn't sounded unique enough to me, but we might revisit that.
 
 arch/arm64/boot/dts/realtek/Makefile               |  1 +
 .../arm64/boot/dts/realtek/rtd1295-probox2-ava.dts | 31 ++++++++++++++++++++++
 arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts  |  6 -----
 arch/arm64/boot/dts/realtek/rtd1295.dtsi           |  6 +++++
 4 files changed, 38 insertions(+), 6 deletions(-)
 create mode 100644 arch/arm64/boot/dts/realtek/rtd1295-probox2-ava.dts

diff --git a/arch/arm64/boot/dts/realtek/Makefile b/arch/arm64/boot/dts/realtek/Makefile
index 8521e921e59a..f43d0209ded7 100644
--- a/arch/arm64/boot/dts/realtek/Makefile
+++ b/arch/arm64/boot/dts/realtek/Makefile
@@ -1,3 +1,4 @@
+dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-probox2-ava.dtb
 dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/realtek/rtd1295-probox2-ava.dts b/arch/arm64/boot/dts/realtek/rtd1295-probox2-ava.dts
new file mode 100644
index 000000000000..8e2b0e75298a
--- /dev/null
+++ b/arch/arm64/boot/dts/realtek/rtd1295-probox2-ava.dts
@@ -0,0 +1,31 @@
+/*
+ * Copyright (c) 2017 Andreas Färber
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+
+/dts-v1/;
+
+#include "rtd1295.dtsi"
+
+/ {
+	compatible = "probox2,ava", "realtek,rtd1295";
+	model = "PROBOX2 AVA";
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x80000000>;
+	};
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&uart0 {
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts b/arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts
index 6efa8091bb30..da19faab29d5 100644
--- a/arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts
+++ b/arch/arm64/boot/dts/realtek/rtd1295-zidoo-x9s.dts
@@ -6,12 +6,6 @@
 
 /dts-v1/;
 
-/memreserve/	0x0000000000000000 0x0000000000030000;
-/memreserve/	0x000000000001f000 0x0000000000001000;
-/memreserve/	0x0000000000030000 0x00000000000d0000;
-/memreserve/	0x0000000001b00000 0x00000000004be000;
-/memreserve/	0x0000000001ffe000 0x0000000000004000;
-
 #include "rtd1295.dtsi"
 
 / {
diff --git a/arch/arm64/boot/dts/realtek/rtd1295.dtsi b/arch/arm64/boot/dts/realtek/rtd1295.dtsi
index 8ae0949ad89e..c0b48953439a 100644
--- a/arch/arm64/boot/dts/realtek/rtd1295.dtsi
+++ b/arch/arm64/boot/dts/realtek/rtd1295.dtsi
@@ -6,6 +6,12 @@
  * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
  */
 
+/memreserve/	0x0000000000000000 0x0000000000030000;
+/memreserve/	0x000000000001f000 0x0000000000001000;
+/memreserve/	0x0000000000030000 0x00000000000d0000;
+/memreserve/	0x0000000001b00000 0x00000000004be000;
+/memreserve/	0x0000000001ffe000 0x0000000000004000;
+
 #include <dt-bindings/clock/realtek,rtd1295.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/reset/realtek,rtd1295.h>
-- 
2.12.3