* [PATCH] watchdog: mei_wdt: constify mei_cl_device_id
@ 2017-08-26 6:11 Arvind Yadav
2017-08-26 9:32 ` Winkler, Tomas
2017-08-30 3:28 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-08-26 6:11 UTC (permalink / raw)
To: tomas.winkler, wim, linux; +Cc: linux-kernel, linux-watchdog
mei_cl_device_id are not supposed to change at runtime. All functions
working with mei_cl_device_id provided by <linux/mei_cl_bus.h> work
with const mei_cl_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/watchdog/mei_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c
index b29c6fd..ea60b29 100644
--- a/drivers/watchdog/mei_wdt.c
+++ b/drivers/watchdog/mei_wdt.c
@@ -670,7 +670,7 @@ static int mei_wdt_remove(struct mei_cl_device *cldev)
#define MEI_UUID_WD UUID_LE(0x05B79A6F, 0x4628, 0x4D7F, \
0x89, 0x9D, 0xA9, 0x15, 0x14, 0xCB, 0x32, 0xAB)
-static struct mei_cl_device_id mei_wdt_tbl[] = {
+static const struct mei_cl_device_id mei_wdt_tbl[] = {
{ .uuid = MEI_UUID_WD, .version = MEI_CL_VERSION_ANY },
/* required last entry */
{ }
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] watchdog: mei_wdt: constify mei_cl_device_id
2017-08-26 6:11 [PATCH] watchdog: mei_wdt: constify mei_cl_device_id Arvind Yadav
@ 2017-08-26 9:32 ` Winkler, Tomas
2017-08-30 3:28 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Winkler, Tomas @ 2017-08-26 9:32 UTC (permalink / raw)
To: Arvind Yadav, wim, linux; +Cc: linux-kernel, linux-watchdog
>
> mei_cl_device_id are not supposed to change at runtime. All functions
> working with mei_cl_device_id provided by <linux/mei_cl_bus.h> work with
> const mei_cl_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Ack.
> ---
> drivers/watchdog/mei_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c index
> b29c6fd..ea60b29 100644
> --- a/drivers/watchdog/mei_wdt.c
> +++ b/drivers/watchdog/mei_wdt.c
> @@ -670,7 +670,7 @@ static int mei_wdt_remove(struct mei_cl_device
> *cldev) #define MEI_UUID_WD UUID_LE(0x05B79A6F, 0x4628, 0x4D7F, \
> 0x89, 0x9D, 0xA9, 0x15, 0x14, 0xCB, 0x32, 0xAB)
>
> -static struct mei_cl_device_id mei_wdt_tbl[] = {
> +static const struct mei_cl_device_id mei_wdt_tbl[] = {
> { .uuid = MEI_UUID_WD, .version = MEI_CL_VERSION_ANY },
> /* required last entry */
> { }
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: watchdog: mei_wdt: constify mei_cl_device_id
2017-08-26 6:11 [PATCH] watchdog: mei_wdt: constify mei_cl_device_id Arvind Yadav
2017-08-26 9:32 ` Winkler, Tomas
@ 2017-08-30 3:28 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2017-08-30 3:28 UTC (permalink / raw)
To: Arvind Yadav; +Cc: tomas.winkler, wim, linux-kernel, linux-watchdog
On Sat, Aug 26, 2017 at 11:41:06AM +0530, Arvind Yadav wrote:
> mei_cl_device_id are not supposed to change at runtime. All functions
> working with mei_cl_device_id provided by <linux/mei_cl_bus.h> work
> with const mei_cl_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mei_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c
> index b29c6fd..ea60b29 100644
> --- a/drivers/watchdog/mei_wdt.c
> +++ b/drivers/watchdog/mei_wdt.c
> @@ -670,7 +670,7 @@ static int mei_wdt_remove(struct mei_cl_device *cldev)
> #define MEI_UUID_WD UUID_LE(0x05B79A6F, 0x4628, 0x4D7F, \
> 0x89, 0x9D, 0xA9, 0x15, 0x14, 0xCB, 0x32, 0xAB)
>
> -static struct mei_cl_device_id mei_wdt_tbl[] = {
> +static const struct mei_cl_device_id mei_wdt_tbl[] = {
> { .uuid = MEI_UUID_WD, .version = MEI_CL_VERSION_ANY },
> /* required last entry */
> { }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-30 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-26 6:11 [PATCH] watchdog: mei_wdt: constify mei_cl_device_id Arvind Yadav
2017-08-26 9:32 ` Winkler, Tomas
2017-08-30 3:28 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome