mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jonathan Whitaker <jon.b.whitaker@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	sayli karnik <karniksayli1995@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
Date: Wed, 30 Aug 2017 12:55:47 +0300	[thread overview]
Message-ID: <20170830094315.ruzixrf54l3tbhe4@mwanda> (raw)
In-Reply-To: <1504061856-12258-1-git-send-email-jon.b.whitaker@gmail.com>

On Tue, Aug 29, 2017 at 08:57:34PM -0600, Jonathan Whitaker wrote:
> It is prefered to use '"%s...", __func__ instead of function names for
> logging. This commit replaces hardcoded function name strings to the
> more preferred '"%s...", __func__' style. These warnings were reported
> by checkpatch.pl.
> 
> Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
> 
> Changes in v2:
>   - Wrapped the changelog text to 72 columns.
>   - Fixed the commit subject to be more clear.
> ---

Put the Changelog under the --- cut off line.

>  drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 9b28ee1..c0e91c3 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>  	unsigned char byte;
>  	int ret;
>  
> -	DPRINTK(5, "ks7010_sdio_probe()\n");
> +	DPRINTK(5, "%s()\n", __func__);

Just delete both the printks.  You can get the same information with
ftrace.

regards,
dan carpenter

  reply	other threads:[~2017-08-30  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  2:57 Jonathan Whitaker
2017-08-30  9:55 ` Dan Carpenter [this message]
2017-08-31  4:24   ` [PATCH v3] " Jonathan Whitaker
2017-08-31  8:07     ` Dan Carpenter
2017-08-31 13:48       ` Jonathan Whitaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830094315.ruzixrf54l3tbhe4@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jon.b.whitaker@gmail.com \
    --cc=karniksayli1995@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®