* [PATCH v4 1/2] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2
2017-09-04 1:16 [PATCH v4 0/2] add thermal nodes for UniPhier SoCs Kunihiko Hayashi
@ 2017-09-04 1:16 ` Kunihiko Hayashi
2017-09-04 1:16 ` [PATCH v4 2/2] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Kunihiko Hayashi
2017-09-04 2:09 ` [PATCH v4 0/2] add thermal nodes for UniPhier SoCs Masahiro Yamada
2 siblings, 0 replies; 5+ messages in thread
From: Kunihiko Hayashi @ 2017-09-04 1:16 UTC (permalink / raw)
To: robh+dt, mark.rutland, yamada.masahiro
Cc: devicetree, linux-arm-kernel, linux-kernel, masami.hiramatsu,
jaswinder.singh, Kunihiko Hayashi
Add nodes of thermal monitor and thermal zone for UniPhier PXs2 SoC.
The thermal monitor is included in sysctrl.
Furthermore, add cpuN labels for reference in cooling-device property.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
arch/arm/boot/dts/uniphier-pxs2.dtsi | 43 ++++++++++++++++++++++++++++++++----
1 file changed, 39 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/uniphier-pxs2.dtsi b/arch/arm/boot/dts/uniphier-pxs2.dtsi
index 90b020c..c89e0d5 100644
--- a/arch/arm/boot/dts/uniphier-pxs2.dtsi
+++ b/arch/arm/boot/dts/uniphier-pxs2.dtsi
@@ -16,7 +16,7 @@
#address-cells = <1>;
#size-cells = <0>;
- cpu@0 {
+ cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a9";
reg = <0>;
@@ -24,9 +24,10 @@
enable-method = "psci";
next-level-cache = <&l2>;
operating-points-v2 = <&cpu_opp>;
+ #cooling-cells = <2>;
};
- cpu@1 {
+ cpu1: cpu@1 {
device_type = "cpu";
compatible = "arm,cortex-a9";
reg = <1>;
@@ -36,7 +37,7 @@
operating-points-v2 = <&cpu_opp>;
};
- cpu@2 {
+ cpu2: cpu@2 {
device_type = "cpu";
compatible = "arm,cortex-a9";
reg = <2>;
@@ -46,7 +47,7 @@
operating-points-v2 = <&cpu_opp>;
};
- cpu@3 {
+ cpu3: cpu@3 {
device_type = "cpu";
compatible = "arm,cortex-a9";
reg = <3>;
@@ -114,6 +115,34 @@
};
};
+ thermal-zones {
+ cpu_thermal {
+ polling-delay-passive = <250>; /* 250ms */
+ polling-delay = <1000>; /* 1000ms */
+ thermal-sensors = <&pvtctl>;
+
+ trips {
+ cpu_crit: cpu_crit {
+ temperature = <95000>; /* 95C */
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ cpu_alert: cpu_alert {
+ temperature = <85000>; /* 85C */
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ };
+
+ cooling-maps {
+ map {
+ trip = <&cpu_alert>;
+ cooling-device = <&cpu0 (-1) (-1)>;
+ };
+ };
+ };
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <1>;
@@ -358,6 +387,12 @@
compatible = "socionext,uniphier-pxs2-reset";
#reset-cells = <1>;
};
+
+ pvtctl: pvtctl {
+ compatible = "socionext,uniphier-pxs2-thermal";
+ interrupts = <0 3 4>;
+ #thermal-sensor-cells = <0>;
+ };
};
nand: nand@68000000 {
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v4 2/2] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20
2017-09-04 1:16 [PATCH v4 0/2] add thermal nodes for UniPhier SoCs Kunihiko Hayashi
2017-09-04 1:16 ` [PATCH v4 1/2] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi
@ 2017-09-04 1:16 ` Kunihiko Hayashi
2017-09-04 2:09 ` [PATCH v4 0/2] add thermal nodes for UniPhier SoCs Masahiro Yamada
2 siblings, 0 replies; 5+ messages in thread
From: Kunihiko Hayashi @ 2017-09-04 1:16 UTC (permalink / raw)
To: robh+dt, mark.rutland, yamada.masahiro
Cc: devicetree, linux-arm-kernel, linux-kernel, masami.hiramatsu,
jaswinder.singh, Kunihiko Hayashi
Add nodes of thermal monitor and thermal zone for UniPhier LD20 SoC.
The thermal monitor is included in sysctrl.
Furthermore, since the reference board doesn't have a calibrated value of
thermal monitor, this patch gives the default value for LD20 reference
board.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
.../arm64/boot/dts/socionext/uniphier-ld20-ref.dts | 4 +++
arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 40 ++++++++++++++++++++++
2 files changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
index 1ca0c86..5bb63a2 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dts
@@ -50,3 +50,7 @@
&i2c0 {
status = "okay";
};
+
+&pvtctl {
+ socionext,tmod-calibration = <0x0f22 0x68ee>;
+};
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
index a29c279..0f733ad 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
@@ -46,6 +46,7 @@
clocks = <&sys_clk 32>;
enable-method = "psci";
operating-points-v2 = <&cluster0_opp>;
+ #cooling-cells = <2>;
};
cpu1: cpu@1 {
@@ -64,6 +65,7 @@
clocks = <&sys_clk 33>;
enable-method = "psci";
operating-points-v2 = <&cluster1_opp>;
+ #cooling-cells = <2>;
};
cpu3: cpu@101 {
@@ -173,6 +175,38 @@
<1 10 4>;
};
+ thermal-zones {
+ cpu_thermal {
+ polling-delay-passive = <250>; /* 250ms */
+ polling-delay = <1000>; /* 1000ms */
+ thermal-sensors = <&pvtctl>;
+
+ trips {
+ cpu_crit: cpu_crit {
+ temperature = <110000>; /* 110C */
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ cpu_alert: cpu_alert {
+ temperature = <100000>; /* 100C */
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert>;
+ cooling-device = <&cpu0 (-1) (-1)>;
+ };
+ map1 {
+ trip = <&cpu_alert>;
+ cooling-device = <&cpu2 (-1) (-1)>;
+ };
+ };
+ };
+ };
+
soc@0 {
compatible = "simple-bus";
#address-cells = <1>;
@@ -410,6 +444,12 @@
watchdog {
compatible = "socionext,uniphier-wdt";
};
+
+ pvtctl: pvtctl {
+ compatible = "socionext,uniphier-ld20-thermal";
+ interrupts = <0 3 4>;
+ #thermal-sensor-cells = <0>;
+ };
};
nand: nand@68000000 {
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4 0/2] add thermal nodes for UniPhier SoCs
2017-09-04 1:16 [PATCH v4 0/2] add thermal nodes for UniPhier SoCs Kunihiko Hayashi
2017-09-04 1:16 ` [PATCH v4 1/2] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2 Kunihiko Hayashi
2017-09-04 1:16 ` [PATCH v4 2/2] arm64: dts: uniphier: add nodes of thermal monitor and thermal zone for LD20 Kunihiko Hayashi
@ 2017-09-04 2:09 ` Masahiro Yamada
2017-09-04 3:55 ` hayashi.kunihiko
2 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2017-09-04 2:09 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
Linux Kernel Mailing List, Masami Hiramatsu, Jassi Brar
Hi.
2017-09-04 10:16 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> This series adds thermal nodes for UniPhier PXs2 and LD20 SoCs.
>
> Changes since v3:
> - rebase on top of linux-next
This repost is a spam.
I left some comments in v3,
but no response from you
nothing was reflected in v4.
> Changes since v2:
> - add the calibration value to device tree for LD20 reference board
>
> Changes since v1:
> - separate from driver's patchset[1]
> - add cooling-maps nodes on the device tree
> - fix an interrupt trigger to set 'level-triggered' according to
> hardware specification
> - bring up threshold temperature for LD20 according to the spec sheet
> - add cpuN labels for reference in cooling-device property on PXs2 dts
>
> [1] https://lkml.org/lkml/2017/6/28/170
>
> Kunihiko Hayashi (2):
> ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for
> PXs2
> arm64: dts: uniphier: add nodes of thermal monitor and thermal zone
> for LD20
>
> arch/arm/boot/dts/uniphier-pxs2.dtsi | 43 ++++++++++++++++++++--
> .../arm64/boot/dts/socionext/uniphier-ld20-ref.dts | 4 ++
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 40 ++++++++++++++++++++
> 3 files changed, 83 insertions(+), 4 deletions(-)
>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 0/2] add thermal nodes for UniPhier SoCs
2017-09-04 2:09 ` [PATCH v4 0/2] add thermal nodes for UniPhier SoCs Masahiro Yamada
@ 2017-09-04 3:55 ` hayashi.kunihiko
0 siblings, 0 replies; 5+ messages in thread
From: hayashi.kunihiko @ 2017-09-04 3:55 UTC (permalink / raw)
To: yamada.masahiro
Cc: robh+dt, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, masami.hiramatsu, jaswinder.singh
On Mon, 4 Sep 2017 11:09:51 +0900 <yamada.masahiro@socionext.com> wrote:
> Hi.
>
>
>
> 2017-09-04 10:16 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> > This series adds thermal nodes for UniPhier PXs2 and LD20 SoCs.
> >
> > Changes since v3:
> > - rebase on top of linux-next
>
>
> This repost is a spam.
>
> I left some comments in v3,
> but no response from you
> nothing was reflected in v4.
Sorry I missed them. I'll reflect your comments and repost them.
Thank you,
>
>
>
>
> > Changes since v2:
> > - add the calibration value to device tree for LD20 reference board
> >
> > Changes since v1:
> > - separate from driver's patchset[1]
> > - add cooling-maps nodes on the device tree
> > - fix an interrupt trigger to set 'level-triggered' according to
> > hardware specification
> > - bring up threshold temperature for LD20 according to the spec sheet
> > - add cpuN labels for reference in cooling-device property on PXs2 dts
> >
> > [1] https://lkml.org/lkml/2017/6/28/170
> >
> > Kunihiko Hayashi (2):
> > ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for
> > PXs2
> > arm64: dts: uniphier: add nodes of thermal monitor and thermal zone
> > for LD20
> >
> > arch/arm/boot/dts/uniphier-pxs2.dtsi | 43 ++++++++++++++++++++--
> > .../arm64/boot/dts/socionext/uniphier-ld20-ref.dts | 4 ++
> > arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 40 ++++++++++++++++++++
> > 3 files changed, 83 insertions(+), 4 deletions(-)
> >
> > --
> > 2.7.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Best Regards
> Masahiro Yamada
---
Kunihiko Hayashi
: hayashi.kunihiko@socionext.com
^ permalink raw reply [flat|nested] 5+ messages in thread