* [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency
@ 2017-09-05 7:58 Arnd Bergmann
2017-09-05 7:58 ` [PATCH 2/2] pinctrl: sprd: add CONFIG_OF dependency Arnd Bergmann
2017-09-12 7:40 ` [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-09-05 7:58 UTC (permalink / raw)
To: Linus Walleij, Baolin Wang; +Cc: Arnd Bergmann, linux-gpio, linux-kernel
The chip-specific driver fails to build when the common
part is not enabled first:
drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove'
drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown'
This adds a Kconfig dependency to ensure this is always
the case.
Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/sprd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
index 6f4a7f9ac6fd..ec21b8bae487 100644
--- a/drivers/pinctrl/sprd/Kconfig
+++ b/drivers/pinctrl/sprd/Kconfig
@@ -13,5 +13,6 @@ config PINCTRL_SPRD
config PINCTRL_SPRD_SC9860
bool "Spreadtrum SC9860 pinctrl driver"
+ depends on PINCTRL_SPRD
help
Say Y here to enable Spreadtrum SC9860 pinctrl driver
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/2] pinctrl: sprd: add CONFIG_OF dependency
2017-09-05 7:58 [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency Arnd Bergmann
@ 2017-09-05 7:58 ` Arnd Bergmann
2017-09-12 7:40 ` [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-09-05 7:58 UTC (permalink / raw)
To: Linus Walleij, Baolin Wang; +Cc: Arnd Bergmann, linux-gpio, linux-kernel
Without CONFIG_OF, we run into a build error:
drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
drivers/pinctrl/sprd/pinctrl-sprd.c:290:8: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
This adds a Kconfig dependency for it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/sprd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
index ec21b8bae487..e75cde2e1b46 100644
--- a/drivers/pinctrl/sprd/Kconfig
+++ b/drivers/pinctrl/sprd/Kconfig
@@ -4,6 +4,7 @@
config PINCTRL_SPRD
bool "Spreadtrum pinctrl driver"
+ depends on OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency
2017-09-05 7:58 [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency Arnd Bergmann
2017-09-05 7:58 ` [PATCH 2/2] pinctrl: sprd: add CONFIG_OF dependency Arnd Bergmann
@ 2017-09-12 7:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-09-12 7:40 UTC (permalink / raw)
To: Arnd Bergmann, Randy Dunlap; +Cc: Baolin Wang, linux-gpio, linux-kernel
On Tue, Sep 5, 2017 at 9:58 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The chip-specific driver fails to build when the common
> part is not enabled first:
>
> drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove'
> drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown'
>
> This adds a Kconfig dependency to ensure this is always
> the case.
>
> Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I got a fix for this and the other problem from Randy Dunlap already.
Thanks anyway!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-12 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 7:58 [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency Arnd Bergmann
2017-09-05 7:58 ` [PATCH 2/2] pinctrl: sprd: add CONFIG_OF dependency Arnd Bergmann
2017-09-12 7:40 ` [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®