* [PATCH] binder: fix an ret value override
@ 2017-09-05 17:25 Todd Kjos
0 siblings, 0 replies; only message in thread
From: Todd Kjos @ 2017-09-05 17:25 UTC (permalink / raw)
To: gregkh, arve, devel, linux-kernel, maco, tkjos, xuyiping,
gengyanping, shiwanglai
Cc: Xu YiPing
From: Xu YiPing <xuyiping@hisilicon.com>
commit 372e3147df70 ("binder: guarantee txn complete / errors delivered
in-order") incorrectly defined a local ret value. This ret value will
be invalid when out of the if block
Signed-off-by: Xu YiPing <xuyiping@hislicon.com>
Signed-off-by: Todd Kjos <tkjos@google.com>
---
drivers/android/binder.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 96cc28afa383..7ef9e7f05e17 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp,
(u64)node->ptr);
binder_node_unlock(node);
} else {
- int ret;
struct binder_ref_data dest_rdata;
binder_node_unlock(node);
--
2.14.1.581.gf28d330327-goog
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-05 17:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 17:25 [PATCH] binder: fix an ret value override Todd Kjos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®