From: Dan Carpenter <dan.carpenter@oracle.com>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos
Date: Sat, 9 Sep 2017 11:48:48 +0300 [thread overview]
Message-ID: <20170908194155.4jp2jrwfdcf2b3wb@mwanda> (raw)
In-Reply-To: <CAPTae5Kt4eZdEX-4GNYnxUApS20FMTbQKPod8xkfSj40EfazjQ@mail.gmail.com>
On Fri, Sep 08, 2017 at 10:43:40AM -0700, Badhri Jagan Sridharan wrote:
> >> /*
> >> - * Select the source PDO providing the most power while staying within
> >> - * the board's voltage limits. Prefer PDO providing exp
> >> + * Select the source PDO providing the most power which has a
> >> + * matchig sink cap. Prefer PDO providing exp
> > ^^^^^^^ ^^^^^^^^^^^^^
> > "matching". What does "providing exp" mean?
>
> Actually that was moved forward from the existing code.
> So not sure what that means ? I can remove it, if needed.
>
If I can't understand it, it probably means that I don't have any
background knowledge, but if you can't understand it then probably no
one can. :P Feel free to delete.
regards,
dan carpenter
next prev parent reply other threads:[~2017-09-09 8:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 1:22 [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Badhri Jagan Sridharan
2017-09-08 1:22 ` [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Badhri Jagan Sridharan
2017-09-08 9:36 ` Dan Carpenter
2017-09-08 17:43 ` Badhri Jagan Sridharan
2017-09-09 8:48 ` Dan Carpenter [this message]
2017-09-09 14:01 ` Guenter Roeck
2017-09-08 9:34 ` [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Dan Carpenter
2017-09-08 17:27 ` Badhri Jagan Sridharan
2017-09-08 19:38 ` Dan Carpenter
2017-09-08 9:45 ` Greg Kroah-Hartman
2017-09-08 17:29 ` Badhri Jagan Sridharan
2017-09-08 19:13 ` Greg Kroah-Hartman
2017-09-09 14:03 ` Guenter Roeck
2017-09-09 16:54 ` Guenter Roeck
2017-09-09 16:58 ` Guenter Roeck
2017-09-10 13:55 ` Greg Kroah-Hartman
2017-09-18 10:20 ` Greg Kroah-Hartman
2017-10-09 22:16 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908194155.4jp2jrwfdcf2b3wb@mwanda \
--to=dan.carpenter@oracle.com \
--cc=badhri@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome