[PATCH] Staging: irda: net: fix coding style issues in irqueue.h

[PATCH] Staging: irda: net: fix coding style issues in irqueue.h

[ArminSchoenlieb]

From: Armin Schoenlieb <armetallica@gmail.com>

This is a patch to the irqueue.h file that fixes up pointer style errors and
trailing whitespace errors, found by the checkpatch.pl tool

Signed-off-by: Armin Schoenlieb <armetallica@gmail.com>
---
 drivers/staging/irda/include/net/irda/irqueue.h | 46 ++++++++++++-------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/irda/include/net/irda/irqueue.h b/drivers/staging/irda/include/net/irda/irqueue.h
index 37f512bd6733..1e7660888e39 100644
--- a/drivers/staging/irda/include/net/irda/irqueue.h
+++ b/drivers/staging/irda/include/net/irda/irqueue.h
@@ -1,5 +1,5 @@
 /*********************************************************************
- *                
+ *
  * Filename:      irqueue.h
  * Version:       0.3
  * Description:   General queue implementation
@@ -8,23 +8,23 @@
  * Created at:    Tue Jun  9 13:26:50 1998
  * Modified at:   Thu Oct  7 13:25:16 1999
  * Modified by:   Dag Brattli <dagb@cs.uit.no>
- * 
+ *
  *     Copyright (C) 1998-1999, Aage Kvalnes <aage@cs.uit.no>
  *     Copyright (c) 1998, Dag Brattli
  *     All Rights Reserved.
- *      
+ *
  *     This code is taken from the Vortex Operating System written by Aage
  *     Kvalnes and has been ported to Linux and Linux/IR by Dag Brattli
  *
- *     This program is free software; you can redistribute it and/or 
- *     modify it under the terms of the GNU General Public License as 
- *     published by the Free Software Foundation; either version 2 of 
+ *     This program is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of
  *     the License, or (at your option) any later version.
- *  
+ *
  *     Neither Dag Brattli nor University of Tromsø admit liability nor
- *     provide warranty for any of this software. This material is 
+ *     provide warranty for any of this software. This material is
  *     provided "AS-IS" and at no charge.
- *     
+ *
  ********************************************************************/
 
 #include <linux/types.h>
@@ -48,7 +48,7 @@
 #define HASHBIN_SIZE   8
 #define HASHBIN_MASK   0x7
 
-#ifndef IRDA_ALIGN 
+#ifndef IRDA_ALIGN
 #define IRDA_ALIGN __attribute__((aligned))
 #endif
 
@@ -71,23 +71,23 @@ typedef struct hashbin_t {
 	int        hb_size;
 	spinlock_t hb_spinlock;		/* HB_LOCK - Can be used by the user */
 
-	irda_queue_t* hb_queue[HASHBIN_SIZE] IRDA_ALIGN;
+	irda_queue_t *hb_queue[HASHBIN_SIZE] IRDA_ALIGN;
 
-	irda_queue_t* hb_current;
+	irda_queue_t *hb_current;
 } hashbin_t;
 
 hashbin_t *hashbin_new(int type);
-int      hashbin_delete(hashbin_t* hashbin, FREE_FUNC func);
-int      hashbin_clear(hashbin_t* hashbin, FREE_FUNC free_func);
-void     hashbin_insert(hashbin_t* hashbin, irda_queue_t* entry, long hashv, 
-			const char* name);
-void*    hashbin_remove(hashbin_t* hashbin, long hashv, const char* name);
-void*    hashbin_remove_first(hashbin_t *hashbin);
-void*	 hashbin_remove_this( hashbin_t* hashbin, irda_queue_t* entry);
-void*    hashbin_find(hashbin_t* hashbin, long hashv, const char* name);
-void*    hashbin_lock_find(hashbin_t* hashbin, long hashv, const char* name);
-void*    hashbin_find_next(hashbin_t* hashbin, long hashv, const char* name,
-			   void ** pnext);
+int hashbin_delete(hashbin_t *hashbin, FREE_FUNC func);
+int hashbin_clear(hashbin_t *hashbin, FREE_FUNC free_func);
+void hashbin_insert(hashbin_t *hashbin, irda_queue_t *entry, long hashv,
+			const char *name);
+void *hashbin_remove(hashbin_t *hashbin, long hashv, const char *name);
+void *hashbin_remove_first(hashbin_t *hashbin);
+void *hashbin_remove_this(hashbin_t *hashbin, irda_queue_t *entry);
+void *hashbin_find(hashbin_t *hashbin, long hashv, const char *name);
+void *hashbin_lock_find(hashbin_t *hashbin, long hashv, const char *name);
+void *hashbin_find_next(hashbin_t *hashbin, long hashv, const char *name,
+			   void **pnext);
 irda_queue_t *hashbin_get_first(hashbin_t *hashbin);
 irda_queue_t *hashbin_get_next(hashbin_t *hashbin);
 
-- 
2.11.0

Re: [PATCH] Staging: irda: net: fix coding style issues in irqueue.h

[Greg KH]

On Mon, Sep 11, 2017 at 10:37:05PM +0200, ArminSchoenlieb wrote:
> From: Armin Schoenlieb <armetallica@gmail.com>
> 
> This is a patch to the irqueue.h file that fixes up pointer style errors and
> trailing whitespace errors, found by the checkpatch.pl tool
> 
> Signed-off-by: Armin Schoenlieb <armetallica@gmail.com>
> ---
>  drivers/staging/irda/include/net/irda/irqueue.h | 46 ++++++++++++-------------
>  1 file changed, 23 insertions(+), 23 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot