mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,
	dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Code Kipper <codekipper@gmail.com>,
	Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v2 01/10] dmaengine: sun6i: Correct setting of clock autogating register for A83T/H3
Date: Mon, 18 Sep 2017 09:57:32 +0200	[thread overview]
Message-ID: <20170918075732.wptp75sh3ovhdukp@flea.lan> (raw)
In-Reply-To: <20170917031956.28010-2-stefan.bruens@rwth-aachen.de>

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

Hi,

On Sun, Sep 17, 2017 at 05:19:47AM +0200, Stefan Brüns wrote:
> The H83T uses a compatible string different from the A23, but requires
> the same clock autogating register setting.
> 
> The H3 also requires setting the clock autogating register, but has
> the register at a different offset.
> 
> Add three suitable callbacks for the existing controller generations
> and set it in the controller config structure.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
> ---
>  drivers/dma/sun6i-dma.c | 31 ++++++++++++++++++++++++++-----
>  1 file changed, 26 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index bcd496edc70f..45bcd5271d94 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -48,6 +48,9 @@
>  #define SUN8I_DMA_GATE		0x20
>  #define SUN8I_DMA_GATE_ENABLE	0x4
>  
> +#define SUNXI_H3_SECURE_REG		0x20
> +#define SUNXI_H3_DMA_GATE		0x28
> +#define SUNXI_H3_DMA_GATE_ENABLE	0x4
>  /*
>   * Channels specific registers
>   */
> @@ -111,7 +114,7 @@ struct sun6i_dma_config {
>  	 * however these SoCs really have and need this bit, as seen in the
>  	 * BSP kernel source code.
>  	 */
> -	bool gate_needed;
> +	void (*clock_autogate_enable)();
>  };
>  
>  /*
> @@ -267,6 +270,20 @@ static inline s8 convert_buswidth(enum dma_slave_buswidth addr_width)
>  	return addr_width >> 1;
>  }
>  
> +static void sun6i_enable_clock_autogate_noop(struct sun6i_dma_dev *sdev)
> +{
> +}

I guess instead of that one, we could just test for the pointer and
not call the function if it's NULL?

Looks good otherwise, once fixed, you have
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2017-09-18  7:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17  3:19 [PATCH v2 00/10] dmaengine: sun6i: Fixes for H3/A83T, enable A64 Stefan Brüns
2017-09-17  3:19 ` [PATCH v2 01/10] dmaengine: sun6i: Correct setting of clock autogating register for A83T/H3 Stefan Brüns
2017-09-18  7:57   ` Maxime Ripard [this message]
2017-09-17  3:19 ` [PATCH v2 02/10] dmaengine: sun6i: Correct burst length field offsets for H3 Stefan Brüns
2017-09-18  7:58   ` Maxime Ripard
2017-09-17  3:19 ` [PATCH v2 03/10] dmaengine: sun6i: Restructure code to allow extension for new SoCs Stefan Brüns
2017-09-18  8:08   ` Maxime Ripard
2017-09-17  3:19 ` [PATCH v2 04/10] dmaengine: sun6i: Enable additional burst lengths/widths on H3 Stefan Brüns
2017-09-18  8:09   ` Maxime Ripard
2017-09-17  3:19 ` [PATCH v2 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct Stefan Brüns
2017-09-18  8:12   ` Maxime Ripard
2017-09-17  3:19 ` [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller Stefan Brüns
2017-09-18  8:11   ` Maxime Ripard
2017-09-18 13:38     ` Brüns, Stefan
2017-09-20 20:53   ` Rob Herring
2017-09-23 23:34     ` Stefan Bruens
2017-09-25  4:12       ` Rob Herring
2017-09-17  3:19 ` [PATCH v2 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree Stefan Brüns
2017-09-18  8:18   ` Maxime Ripard
2017-09-17  3:19 ` [PATCH v2 08/10] dmaengine: sun6i: Add support for Allwinner A64 and compatibles Stefan Brüns
2017-09-18  8:19   ` Maxime Ripard
2017-09-17  3:19 ` [PATCH v2 09/10] arm64: allwinner: a64: Add device node for DMA controller Stefan Brüns
2017-09-17  3:19 ` [PATCH v2 10/10] arm64: allwinner: a64: add dma controller references to spi nodes Stefan Brüns
     [not found] ` <2791817.czGZyN6WKS@sbruens-linux>
     [not found]   ` <20170919142508.woslovwjtecgygpo@flea.lan>
2017-09-19 16:17     ` [PATCH v2 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree Brüns, Stefan
2017-09-22 21:30       ` Maxime Ripard
2017-09-23  0:00         ` Brüns, Stefan
2017-09-27  9:09           ` Maxime Ripard
2017-09-27 23:10             ` Stefan Bruens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918075732.wptp75sh3ovhdukp@flea.lan \
    --to=maxime.ripard@free-electrons.com \
    --cc=andre.przywara@arm.com \
    --cc=codekipper@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan.bruens@rwth-aachen.de \
    --cc=vinod.koul@intel.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®