From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Code Kipper <codekipper@gmail.com>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v2 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree
Date: Mon, 18 Sep 2017 10:18:24 +0200 [thread overview]
Message-ID: <20170918081824.iiebcj63wvnean57@flea.lan> (raw)
In-Reply-To: <20170917031956.28010-8-stefan.bruens@rwth-aachen.de>
[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]
Hi,
On Sun, Sep 17, 2017 at 05:19:53AM +0200, Stefan Brüns wrote:
> + ret = of_property_read_u32(np, "dma-channels", &sdc->num_pchans);
> + if (ret && !sdc->num_pchans) {
> + dev_err(&pdev->dev, "Can't get dma-channels.\n");
> + return ret;
> + }
> +
> + if (sdc->num_pchans > DMA_MAX_CHANNELS) {
> + dev_err(&pdev->dev, "Number of dma-channels out of range.\n");
> + return -EINVAL;
> + }
> +
> + ret = of_property_read_u32(np, "dma-requests", &sdc->max_request);
> + if (ret && !sdc->max_request) {
> + dev_info(&pdev->dev, "Missing dma-requests, using %u.\n",
> + DMA_CHAN_MAX_DRQ);
> + sdc->max_request = DMA_CHAN_MAX_DRQ;
> + }
> +
> + if (sdc->max_request > DMA_CHAN_MAX_DRQ) {
> + dev_err(&pdev->dev, "Value of dma-requests out of range.\n");
> + return -EINVAL;
> + }
I'm not really convinced about these two checks. They don't catch all
errors (the range between the actual number of channels / DRQ and the
maximum allowed per the registers), they might increase in the future
too, and if we want to make that check actually working, we would have
to duplicate the number of requests and channels into the driver.
Which is kind of the opposite of what we're trying to do here :)
Once removed,
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-09-18 8:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 3:19 [PATCH v2 00/10] dmaengine: sun6i: Fixes for H3/A83T, enable A64 Stefan Brüns
2017-09-17 3:19 ` [PATCH v2 01/10] dmaengine: sun6i: Correct setting of clock autogating register for A83T/H3 Stefan Brüns
2017-09-18 7:57 ` Maxime Ripard
2017-09-17 3:19 ` [PATCH v2 02/10] dmaengine: sun6i: Correct burst length field offsets for H3 Stefan Brüns
2017-09-18 7:58 ` Maxime Ripard
2017-09-17 3:19 ` [PATCH v2 03/10] dmaengine: sun6i: Restructure code to allow extension for new SoCs Stefan Brüns
2017-09-18 8:08 ` Maxime Ripard
2017-09-17 3:19 ` [PATCH v2 04/10] dmaengine: sun6i: Enable additional burst lengths/widths on H3 Stefan Brüns
2017-09-18 8:09 ` Maxime Ripard
2017-09-17 3:19 ` [PATCH v2 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct Stefan Brüns
2017-09-18 8:12 ` Maxime Ripard
2017-09-17 3:19 ` [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller Stefan Brüns
2017-09-18 8:11 ` Maxime Ripard
2017-09-18 13:38 ` Brüns, Stefan
2017-09-20 20:53 ` Rob Herring
2017-09-23 23:34 ` Stefan Bruens
2017-09-25 4:12 ` Rob Herring
2017-09-17 3:19 ` [PATCH v2 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree Stefan Brüns
2017-09-18 8:18 ` Maxime Ripard [this message]
2017-09-17 3:19 ` [PATCH v2 08/10] dmaengine: sun6i: Add support for Allwinner A64 and compatibles Stefan Brüns
2017-09-18 8:19 ` Maxime Ripard
2017-09-17 3:19 ` [PATCH v2 09/10] arm64: allwinner: a64: Add device node for DMA controller Stefan Brüns
2017-09-17 3:19 ` [PATCH v2 10/10] arm64: allwinner: a64: add dma controller references to spi nodes Stefan Brüns
[not found] ` <2791817.czGZyN6WKS@sbruens-linux>
[not found] ` <20170919142508.woslovwjtecgygpo@flea.lan>
2017-09-19 16:17 ` [PATCH v2 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree Brüns, Stefan
2017-09-22 21:30 ` Maxime Ripard
2017-09-23 0:00 ` Brüns, Stefan
2017-09-27 9:09 ` Maxime Ripard
2017-09-27 23:10 ` Stefan Bruens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918081824.iiebcj63wvnean57@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
--cc=vinod.koul@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®