mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block
@ 2017-09-20 15:39 Masahiro Yamada
  2017-09-21  9:42 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2017-09-20 15:39 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Jakub Kicinski, Masahiro Yamada, linux-kernel, David S. Miller

I do not see anything that restricts this macro to 32 bit width.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 include/linux/bitfield.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h
index 9e16b33..1030651 100644
--- a/include/linux/bitfield.h
+++ b/include/linux/bitfield.h
@@ -92,7 +92,7 @@
 /**
  * FIELD_GET() - extract a bitfield element
  * @_mask: shifted mask defining the field's length and position
- * @_reg:  32bit value of entire bitfield
+ * @_reg:  value of entire bitfield
  *
  * FIELD_GET() extracts the field specified by @_mask from the
  * bitfield passed in as @_reg by masking and shifting it down.
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block
  2017-09-20 15:39 [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block Masahiro Yamada
@ 2017-09-21  9:42 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2017-09-21  9:42 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: Andrew Morton, linux-kernel, David S. Miller

On Thu, 21 Sep 2017 00:39:35 +0900, Masahiro Yamada wrote:
> I do not see anything that restricts this macro to 32 bit width.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Looks like a leftover from v1 of the code, thanks for cleaning it up!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-21  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 15:39 [PATCH] bitfield.h: remove 32bit from FIELD_GET comment block Masahiro Yamada
2017-09-21  9:42 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome