* [PATCH RESEND] fs/cachefiles: Remove unnecessary comparisons in bind.c
@ 2017-09-24 17:55 Christos Gkekas
0 siblings, 0 replies; only message in thread
From: Christos Gkekas @ 2017-09-24 17:55 UTC (permalink / raw)
To: David Howells, linux-cachefs, linux-kernel; +Cc: Christos Gkekas
cache->fstop_percent and cache->bstop_percent are unsigned so they are
always >= 0. There is no point in asserting this.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
fs/cachefiles/bind.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/cachefiles/bind.c b/fs/cachefiles/bind.c
index d9f0010..105ac53 100644
--- a/fs/cachefiles/bind.c
+++ b/fs/cachefiles/bind.c
@@ -40,13 +40,11 @@ int cachefiles_daemon_bind(struct cachefiles_cache *cache, char *args)
args);
/* start by checking things over */
- ASSERT(cache->fstop_percent >= 0 &&
- cache->fstop_percent < cache->fcull_percent &&
+ ASSERT(cache->fstop_percent < cache->fcull_percent &&
cache->fcull_percent < cache->frun_percent &&
cache->frun_percent < 100);
- ASSERT(cache->bstop_percent >= 0 &&
- cache->bstop_percent < cache->bcull_percent &&
+ ASSERT(cache->bstop_percent < cache->bcull_percent &&
cache->bcull_percent < cache->brun_percent &&
cache->brun_percent < 100);
--
2.7.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-24 17:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-24 17:55 [PATCH RESEND] fs/cachefiles: Remove unnecessary comparisons in bind.c Christos Gkekas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®