From: Guenter Roeck <linux@roeck-us.net>
To: David Binderman <dcb314@hotmail.com>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition
Date: Mon, 25 Sep 2017 07:58:21 -0700 [thread overview]
Message-ID: <20170925145821.GA29763@roeck-us.net> (raw)
In-Reply-To: <VI1PR0802MB23367050B5690DAC7D654F0B9C7A0@VI1PR0802MB2336.eurprd08.prod.outlook.com>
On Mon, Sep 25, 2017 at 01:54:02PM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition: upper. '!upper || (upper && data->has_status_word)' is equivalent to '!upper || data->has_status_word'
>
> Source code is
>
> (!upper || (upper && data->has_status_word)) &&
>
Please feel free to submit a patch.
Thanks,
Guenter
parent reply other threads:[~2017-09-25 14:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <VI1PR0802MB23367050B5690DAC7D654F0B9C7A0@VI1PR0802MB2336.eurprd08.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925145821.GA29763@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dcb314@hotmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®