* [PATCH 1/2] vfs: remove unneeded unlikely()
@ 2017-09-25 18:21 Hirofumi Nakagawa
2017-09-25 18:21 ` [PATCH 2/2] pstore: " Hirofumi Nakagawa
0 siblings, 1 reply; 2+ messages in thread
From: Hirofumi Nakagawa @ 2017-09-25 18:21 UTC (permalink / raw)
To: viro, keescook, anton, ccross, tony.luck, linux-fsdevel, linux-kernel
Cc: Hirofumi Nakagawa
IS_ERR() macro it is already including unlikely().
Signed-off-by: Hirofumi Nakagawa <nklabs@gmail.com>
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namei.c b/fs/namei.c
index c75ea03ca147..00384488fda1 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3458,7 +3458,7 @@ static int do_tmpfile(struct nameidata *nd, unsigned flags,
goto out;
child = vfs_tmpfile(path.dentry, op->mode, op->open_flag);
error = PTR_ERR(child);
- if (unlikely(IS_ERR(child)))
+ if (IS_ERR(child))
goto out2;
dput(path.dentry);
path.dentry = child;
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] pstore: remove unneeded unlikely()
2017-09-25 18:21 [PATCH 1/2] vfs: remove unneeded unlikely() Hirofumi Nakagawa
@ 2017-09-25 18:21 ` Hirofumi Nakagawa
0 siblings, 0 replies; 2+ messages in thread
From: Hirofumi Nakagawa @ 2017-09-25 18:21 UTC (permalink / raw)
To: viro, keescook, anton, ccross, tony.luck, linux-fsdevel, linux-kernel
Cc: Hirofumi Nakagawa
IS_ERR() macro it is already including unlikely().
Signed-off-by: Hirofumi Nakagawa <nklabs@gmail.com>
---
fs/pstore/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 2b21d180157c..7256149af306 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -654,7 +654,7 @@ static int pstore_write_user_compat(struct pstore_record *record,
return -EINVAL;
record->buf = memdup_user(buf, record->size);
- if (unlikely(IS_ERR(record->buf))) {
+ if (IS_ERR(record->buf)) {
ret = PTR_ERR(record->buf);
goto out;
}
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-25 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-25 18:21 [PATCH 1/2] vfs: remove unneeded unlikely() Hirofumi Nakagawa
2017-09-25 18:21 ` [PATCH 2/2] pstore: " Hirofumi Nakagawa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome