mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boqun Feng <boqun.feng@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Gautham R Shenoy <ego@linux.vnet.ibm.com>,
	Byungchul Park <byungchul.park@lge.com>,
	Boqun Feng <boqun.feng@gmail.com>
Subject: [RFC tip/locking/lockdep v3 14/14] Revert "locking/lockdep/selftests: Fix mixed read-write ABBA tests"
Date: Tue, 26 Sep 2017 06:18:48 +0800	[thread overview]
Message-ID: <20170925221848.6646-15-boqun.feng@gmail.com> (raw)
In-Reply-To: <20170925221848.6646-1-boqun.feng@gmail.com>

This reverts commit d82fed75294229abc9d757f08a4817febae6c4f4.

Since we now could handle mixed read-write deadlock detection well, the
self tests could be detected as expected, no need to use this
work-around.

Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
 lib/locking-selftest.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index 0fe16f06ed00..1a28d68ec8b6 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -2265,12 +2265,6 @@ void locking_selftest(void)
 	print_testname("mixed read-lock/lock-write ABBA");
 	pr_cont("             |");
 	dotest(rlock_ABBA1, FAILURE, LOCKTYPE_RWLOCK);
-	/*
-	 * Lockdep does indeed fail here, but there's nothing we can do about
-	 * that now.  Don't kill lockdep for it.
-	 */
-	unexpected_testcase_failures--;
-
 	pr_cont("             |");
 	dotest(rwsem_ABBA1, FAILURE, LOCKTYPE_RWSEM);
 
-- 
2.14.1

      parent reply	other threads:[~2017-09-25 22:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 22:18 [RFC tip/locking/lockdep v3 00/14] lockdep: Support deadlock detection for recursive read locks Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 01/14] lockdep: Demagic the return value of BFS Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 02/14] lockdep: Make __bfs() visit every dependency until a match Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 03/14] lockdep: Redefine LOCK_*_STATE* bits Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 04/14] lockdep: Introduce lock_list::dep Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 05/14] lockdep: Extend __bfs() to work with multiple kinds of dependencies Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 06/14] lockdep: Support deadlock detection for recursive read in check_noncircular() Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 07/14] lockdep: Adjust check_redundant() for recursive read change Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 08/14] lockdep: Fix recursive read lock related safe->unsafe detection Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 09/14] lockdep: Add recursive read locks into dependency graph Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 10/14] lockdep/selftest: Add a R-L/L-W test case specific to chain cache behavior Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 11/14] lockdep: Take read/write status in consideration when generate chainkey Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 12/14] lockdep/selftest: Unleash irq_read_recursion2 and add more Boqun Feng
2017-09-25 22:18 ` [RFC tip/locking/lockdep v3 13/14] lockdep/selftest: Add more recursive read related test cases Boqun Feng
2017-09-25 22:18 ` Boqun Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170925221848.6646-15-boqun.feng@gmail.com \
    --to=boqun.feng@gmail.com \
    --cc=byungchul.park@lge.com \
    --cc=ego@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®