From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: Re: sched: serial port lockdep warning when offlining CPUs
Date: Thu, 28 Sep 2017 11:45:30 +0000 [thread overview]
Message-ID: <20170928114528.wilknwkyjecqrcaa@sasha-lappy> (raw)
In-Reply-To: <20170928113607.GB30818@jagdpanzerIV.localdomain>
On Thu, Sep 28, 2017 at 08:36:07PM +0900, Sergey Senozhatsky wrote:
>On (09/28/17 19:30), Sergey Senozhatsky wrote:
>> lib/ratelimit.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/ratelimit.c b/lib/ratelimit.c
>> index 08f8043cac61..bddc55834c2e 100644
>> --- a/lib/ratelimit.c
>> +++ b/lib/ratelimit.c
>> @@ -48,7 +48,8 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
>> if (time_is_before_jiffies(rs->begin + rs->interval)) {
>> if (rs->missed) {
>> if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
>> - pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);
>> + printk_deferred(KERN_WARN "%s: %d callbacks suppressed\n",
>
>oops... s/KERN_WARN/KERN_WARNING/
>
>sorry about that.
Okay, that seems to have delt with the callbacks supressed issue.
I also seem to be hitting it as a result of the scheduler triggering a WARN, where print_stack_trace(), for example, just uses printk().
Now I'm not sure what's your approach here, do we keep converting printk to printk_deferred one by one until we whacked every mole?
--
Thanks,
Sasha
next prev parent reply other threads:[~2017-09-28 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 9:19 Sasha Levin
2017-09-28 9:38 ` Peter Zijlstra
2017-09-28 10:30 ` Sergey Senozhatsky
2017-09-28 11:36 ` Sergey Senozhatsky
2017-09-28 11:45 ` Levin, Alexander (Sasha Levin) [this message]
2017-09-28 11:55 ` Sergey Senozhatsky
2017-09-28 12:05 ` Peter Zijlstra
2017-09-28 12:07 ` Peter Zijlstra
2017-09-28 12:15 ` Sergey Senozhatsky
2017-09-28 12:28 ` Peter Zijlstra
2017-09-28 11:47 ` Peter Zijlstra
2017-09-28 11:51 ` Sergey Senozhatsky
2017-09-28 11:04 ` Levin, Alexander (Sasha Levin)
2017-09-28 11:13 ` Sergey Senozhatsky
2017-09-28 11:38 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928114528.wilknwkyjecqrcaa@sasha-lappy \
--to=alexander.levin@verizon.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®