From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sasha Levin <levinsasha928@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
alexander.levin@verizon.com, pmladek@suse.com,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org
Subject: Re: sched: serial port lockdep warning when offlining CPUs
Date: Thu, 28 Sep 2017 20:51:18 +0900 [thread overview]
Message-ID: <20170928115118.GA687@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170928114705.4a2iaek26qcdo7qk@hirez.programming.kicks-ass.net>
On (09/28/17 13:47), Peter Zijlstra wrote:
> On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote:
> > ---
> >
> > lib/ratelimit.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/ratelimit.c b/lib/ratelimit.c
> > index 08f8043cac61..bddc55834c2e 100644
> > --- a/lib/ratelimit.c
> > +++ b/lib/ratelimit.c
> > @@ -48,7 +48,8 @@ int ___ratelimit(struct ratelimit_state *rs, const char *func)
> > if (time_is_before_jiffies(rs->begin + rs->interval)) {
> > if (rs->missed) {
> > if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) {
> > - pr_warn("%s: %d callbacks suppressed\n", func, rs->missed);
> > + printk_deferred(KERN_WARN "%s: %d callbacks suppressed\n",
> > + func, rs->missed);
> > rs->missed = 0;
> > }
> > }
>
> Oh cute; I figured it was the syslog daemon suppressing multiple
> identical lines, but yes the above looks very plausible.
seems to be stable v4.8+ material.
Fixes: 6b1d174b0c27b ("ratelimit: extend to print suppressed messages on release")
I'll send out a patch.
-ss
next prev parent reply other threads:[~2017-09-28 11:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 9:19 Sasha Levin
2017-09-28 9:38 ` Peter Zijlstra
2017-09-28 10:30 ` Sergey Senozhatsky
2017-09-28 11:36 ` Sergey Senozhatsky
2017-09-28 11:45 ` Levin, Alexander (Sasha Levin)
2017-09-28 11:55 ` Sergey Senozhatsky
2017-09-28 12:05 ` Peter Zijlstra
2017-09-28 12:07 ` Peter Zijlstra
2017-09-28 12:15 ` Sergey Senozhatsky
2017-09-28 12:28 ` Peter Zijlstra
2017-09-28 11:47 ` Peter Zijlstra
2017-09-28 11:51 ` Sergey Senozhatsky [this message]
2017-09-28 11:04 ` Levin, Alexander (Sasha Levin)
2017-09-28 11:13 ` Sergey Senozhatsky
2017-09-28 11:38 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928115118.GA687@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=alexander.levin@verizon.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®