From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Benson Leung <bleung@chromium.org>,
gwendal@chromium.org, groeck@chromium.org,
linux-kernel@vger.kernel.org, thierry.escande@collabora.com
Subject: Re: [PATCH] mfd: cros_ec: move cros_ec_dev driver to MFD subdir.
Date: Thu, 28 Sep 2017 20:22:44 +0100 [thread overview]
Message-ID: <20170928192244.rtmoovk22zwfsl2x@dell> (raw)
In-Reply-To: <20170925200447.6356-1-enric.balletbo@collabora.com>
On Mon, 25 Sep 2017, Enric Balletbo i Serra wrote:
> The cros_ec_dev serves multiple purposes, one is register dinamically the
> MFD subdevices by checking the features available in a specific ChromeOS
> Embedded Controller, hence there are different calls to mfd_add_devices.
> The first time we upstreamed this driver was placed in
> drivers/platform/chrome, but call mfd_add_devices outside MFD is wrong.
> As cros_ec_dev driver is strongly related to the MFD cros-ec-core would
> make sense move the driver to the mfd subdir.
>
> This patch also fixes a small module loading issue, the name of the driver
> in the C code was not matching their Makefile names, this prevented the
> driver from loaded as module.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/mfd/Kconfig | 9 +++++++++
> drivers/mfd/Makefile | 4 ++++
> drivers/{platform/chrome => mfd}/cros_ec_debugfs.c | 0
> drivers/{platform/chrome => mfd}/cros_ec_debugfs.h | 0
> drivers/{platform/chrome => mfd}/cros_ec_dev.c | 5 ++++-
> drivers/{platform/chrome => mfd}/cros_ec_dev.h | 0
> drivers/{platform/chrome => mfd}/cros_ec_lightbar.c | 0
> drivers/{platform/chrome => mfd}/cros_ec_sysfs.c | 0
> drivers/{platform/chrome => mfd}/cros_ec_vbc.c | 0
> drivers/platform/chrome/Kconfig | 9 ---------
> drivers/platform/chrome/Makefile | 4 ----
> 11 files changed, 17 insertions(+), 14 deletions(-)
> rename drivers/{platform/chrome => mfd}/cros_ec_debugfs.c (100%)
> rename drivers/{platform/chrome => mfd}/cros_ec_debugfs.h (100%)
> rename drivers/{platform/chrome => mfd}/cros_ec_dev.c (99%)
> rename drivers/{platform/chrome => mfd}/cros_ec_dev.h (100%)
> rename drivers/{platform/chrome => mfd}/cros_ec_lightbar.c (100%)
> rename drivers/{platform/chrome => mfd}/cros_ec_sysfs.c (100%)
> rename drivers/{platform/chrome => mfd}/cros_ec_vbc.c (100%)
This is not what I had in mind.
Only the MFD portion (the part which registers other devices) should
live in drivers/mfd. Everything else should either live in their
respective subsystem(s) or in drivers/platform.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2017-09-28 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 20:04 Enric Balletbo i Serra
2017-09-28 19:22 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928192244.rtmoovk22zwfsl2x@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®