From: David Miller <davem@davemloft.net>
To: madalin.bucur@nxp.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsl/fman: remove of_node
Date: Mon, 02 Oct 2017 16:04:45 -0700 (PDT) [thread overview]
Message-ID: <20171002.160445.737065995396076298.davem@davemloft.net> (raw)
In-Reply-To: <1506940297-20442-1-git-send-email-madalin.bucur@nxp.com>
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Mon, 2 Oct 2017 13:31:37 +0300
> The FMan MAC driver allocates a platform device for the Ethernet
> driver to probe on. Setting pdev->dev.of_node with the MAC node
> triggers the MAC driver probing of the new platform device. While
> this fails quickly and does not affect the functionality of the
> drivers, it is incorrect and must be removed. This was added to
> address a report that DSA code using of_find_net_device_by_node()
> is unable to use the DPAA interfaces. Error message seen before
> this fix:
>
> fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed
> fsl_mac: probe of dpaa-ethernet.0 failed with error -16
>
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
Is the DSA issue no longer something we need to be concerned
about? If not, why? You have to explain this.
next prev parent reply other threads:[~2017-10-02 23:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 10:31 Madalin Bucur
2017-10-02 23:04 ` David Miller [this message]
2017-10-03 8:49 ` Madalin-cristian Bucur
2017-10-03 13:00 ` Andrew Lunn
2017-10-04 9:59 ` Madalin-cristian Bucur
2017-10-04 13:09 ` Andrew Lunn
2017-10-04 4:43 ` David Miller
2017-10-04 9:53 ` Madalin-cristian Bucur
2017-10-10 14:01 ` Madalin-cristian Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002.160445.737065995396076298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®