From: Andrew Lunn <andrew@lunn.ch>
To: Razvan Stefanescu <razvan.stefanescu@nxp.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
agraf@suse.de, arnd@arndb.de, alexandru.marginean@nxp.com,
bogdan.purcareata@nxp.com, ruxandra.radulescu@nxp.com,
laurentiu.tudor@nxp.com, stuyoder@gmail.com
Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support
Date: Mon, 2 Oct 2017 17:37:18 +0200 [thread overview]
Message-ID: <20171002153718.GJ17713@lunn.ch> (raw)
In-Reply-To: <1506933380-12641-4-git-send-email-razvan.stefanescu@nxp.com>
Hi Razvan
> +static void ethsw_get_drvinfo(struct net_device *netdev,
> + struct ethtool_drvinfo *drvinfo)
> +{
> + struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> + u16 version_major, version_minor;
> + int err;
> +
> + strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
> + strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version));
Software driver versions are mostly useless. I would suggest you
remove this.
Andrew
next prev parent reply other threads:[~2017-10-02 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 8:36 [PATCH v2 0/6] staging: Introduce DPAA2 Ethernet Switch driver Razvan Stefanescu
2017-10-02 8:36 ` [PATCH v2 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object Razvan Stefanescu
2017-10-02 8:36 ` [PATCH v2 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver Razvan Stefanescu
2017-10-02 8:36 ` [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support Razvan Stefanescu
2017-10-02 15:37 ` Andrew Lunn [this message]
2017-10-03 5:22 ` Razvan Stefanescu
2017-10-02 8:36 ` [PATCH v2 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver Razvan Stefanescu
2017-10-02 8:36 ` [PATCH v2 5/6] staging: fsl-dpaa2/ethsw: Add README Razvan Stefanescu
2017-10-02 8:36 ` [PATCH v2 6/6] staging: fsl-dpaa2/ethsw: Add TODO Razvan Stefanescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002153718.GJ17713@lunn.ch \
--to=andrew@lunn.ch \
--cc=agraf@suse.de \
--cc=alexandru.marginean@nxp.com \
--cc=arnd@arndb.de \
--cc=bogdan.purcareata@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razvan.stefanescu@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®