From: Greg KH <gregkh@linuxfoundation.org>
To: sunil.m@techveda.org
Cc: gilad@benyossef.com, linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
karthik@techveda.org
Subject: Re: [PATCH v2] staging: ccree: Convert to platform_{get,set}_drvdata()
Date: Tue, 3 Oct 2017 18:29:20 +0200 [thread overview]
Message-ID: <20171003162920.GA11186@kroah.com> (raw)
In-Reply-To: <1505996262-19137-1-git-send-email-sunil.m@techveda.org>
On Thu, Sep 21, 2017 at 05:47:42PM +0530, sunil.m@techveda.org wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
>
> Platform devices are expected to use wrapper functions,
> platform_{get,set}_drvdata() with platform_device as argument,
> for getting and setting the driver data. dev_{get,set}_drvdata()
> are using &plat_dev->dev.
> For wrapper functions we can directly pass a struct platform_device.
>
> dev_set_drvdata() is redundant and therefore removed. The driver core
> clears the driver data to NULL after device_release or on probe failure.
>
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
> ---
> Changes for v2:
> - Rebased on top of staging-testing.
Can you rebase again, this still does not apply :(
next prev parent reply other threads:[~2017-10-03 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 11:29 [PATCH] " sunil.m
2017-09-21 12:17 ` [PATCH v2] " sunil.m
2017-10-03 16:29 ` Greg KH [this message]
2017-10-04 7:45 ` [PATCH v3] " sunil.m
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003162920.GA11186@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=karthik@techveda.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.m@techveda.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome