mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>,
	linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v7 2/2] tracing: Add support for preempt and irq enable/disable events
Date: Wed, 4 Oct 2017 12:44:14 -0400	[thread overview]
Message-ID: <20171004124414.43115067@gandalf.local.home> (raw)
In-Reply-To: <20171004160434.hfd7rbefqvi3lz22@hirez.programming.kicks-ass.net>

On Wed, 4 Oct 2017 18:04:34 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Sep 29, 2017 at 02:22:45PM -0700, Joel Fernandes wrote:
> > +++ b/kernel/trace/trace_irqsoff.c  
> 
> >  EXPORT_SYMBOL(trace_hardirqs_on);
> >  EXPORT_SYMBOL(trace_hardirqs_off);
> >  EXPORT_SYMBOL(trace_hardirqs_on_caller);
> >  EXPORT_SYMBOL(trace_hardirqs_off_caller);  
> 
> Steve, how does this compiler with lockdep enabled? Because:
> 
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on_caller);
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on);
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off_caller);
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off);

I'll have to see if it does, I haven't applied them yet. Looks like
they were removed from the:

#ifdef CONFIG_PROVE_LOCKING

[..]

#else /* !CONFIG_PROVE_LOCKING */

<here>

#endif


I don't see the protection in the patches. I will definitely test that
before pushing it anywhere.

-- Steve

  parent reply	other threads:[~2017-10-04 16:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 21:22 [PATCH v7 1/2] tracing: Prepare to add preempt and irq trace events Joel Fernandes
2017-09-29 21:22 ` [PATCH v7 2/2] tracing: Add support for preempt and irq enable/disable events Joel Fernandes
2017-10-04 16:01   ` Peter Zijlstra
2017-10-04 16:43     ` Joel Fernandes
2017-10-06  8:59       ` Joel Fernandes
2017-10-05 23:28     ` Joel Fernandes
2017-10-05 23:29       ` Joel Fernandes
2017-10-06  7:07       ` Peter Zijlstra
2017-10-06  7:28         ` Joel Fernandes
2017-10-06 13:38           ` Steven Rostedt
2017-10-06 17:27             ` Joel Fernandes
2017-10-04 16:04   ` Peter Zijlstra
2017-10-04 16:31     ` Joel Fernandes
2017-10-04 16:44     ` Steven Rostedt [this message]
2017-10-04 16:56       ` Joel Fernandes
2017-10-04 17:03         ` Steven Rostedt
2017-10-04 20:13           ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004124414.43115067@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=joelaf@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®