From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/kvm: Move kvm_fastop_exception to .fixup section
Date: Wed, 4 Oct 2017 10:36:10 -0500 [thread overview]
Message-ID: <20171004153610.b2vuraixglgqbfz6@treble> (raw)
In-Reply-To: <20171004151636.GA30935@roeck-us.net>
On Wed, Oct 04, 2017 at 08:16:36AM -0700, Guenter Roeck wrote:
> On Wed, Oct 04, 2017 at 09:43:06AM -0500, Josh Poimboeuf wrote:
> > When compiling the kernel with the '-frecord-gcc-switches' flag, objtool
> > complains:
> >
> > arch/x86/kvm/emulate.o: warning: objtool: .GCC.command.line+0x0: special: can't find new instruction
> >
> > And also the kernel fails to link.
> >
> > The problem is that the 'kvm_fastop_exception' code gets placed into the
> > throwaway '.GCC.command.line' section instead of '.text'.
> >
> > Exception fixup code is conventionally placed in the '.fixup' section,
> > so put it there where it belongs.
> >
> > Reported-and-tested-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> Thanks!
I forgot to add the kvm maintainers to CC. Will resend.
--
Josh
next prev parent reply other threads:[~2017-10-04 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 14:43 Josh Poimboeuf
2017-10-04 15:16 ` Guenter Roeck
2017-10-04 15:36 ` Josh Poimboeuf [this message]
2017-10-04 15:39 Josh Poimboeuf
2017-10-05 6:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004153610.b2vuraixglgqbfz6@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®