From: David Miller <davem@davemloft.net>
To: pebolle@tiscali.nl
Cc: keescook@chromium.org, isdn@linux-pingi.de, johan@kernel.org,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup()
Date: Thu, 05 Oct 2017 09:53:09 -0700 (PDT) [thread overview]
Message-ID: <20171005.095309.1742522481534840543.davem@davemloft.net> (raw)
In-Reply-To: <1507190336.2167.5.camel@tiscali.nl>
From: Paul Bolle <pebolle@tiscali.nl>
Date: Thu, 05 Oct 2017 09:58:56 +0200
> Hi Kees,
>
> On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote:
>> Also uses kzmalloc to replace open-coded field assignments to NULL and zero.
>
> If I'm allowed to whine (chances that I'm allowed to do that are not so great
> as Dave tends to apply gigaset patches before I even have a chance to look at
> them properly!): I'd prefer it if that was done separately in a preceding
> patch. Would that bother you?
Agreed, these timer transformations are already exhausting to review without
unrelated modifications sneaking in.
next prev parent reply other threads:[~2017-10-05 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 0:52 Kees Cook
2017-10-05 7:58 ` Paul Bolle
2017-10-05 16:53 ` David Miller [this message]
2017-10-05 19:17 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005.095309.1742522481534840543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=isdn@linux-pingi.de \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®