* [PATCH 0/3] Cocci spatch "of_table" - v4.14-rc1
@ 2017-09-21 6:24 Thomas Meyer
2017-09-21 6:24 ` [PATCH 2/3] i2c: Cocci spatch "of_table" Thomas Meyer
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Thomas Meyer @ 2017-09-21 6:24 UTC (permalink / raw)
To: linux-kernel
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of patches.
I can exclude you by path; e.g. all findings in "drivers/scsi" will never
be reported again by this semi-automatic program runs.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/3] i2c: Cocci spatch "of_table" 2017-09-21 6:24 [PATCH 0/3] Cocci spatch "of_table" - v4.14-rc1 Thomas Meyer @ 2017-09-21 6:24 ` Thomas Meyer 2017-10-05 11:26 ` Wolfram Sang 2017-09-21 6:24 ` [PATCH 1/3] ARM: mediatek: " Thomas Meyer 2017-09-21 6:24 ` [PATCH 3/3] net: stmmac: " Thomas Meyer 2 siblings, 1 reply; 6+ messages in thread From: Thomas Meyer @ 2017-09-21 6:24 UTC (permalink / raw) To: wsa, linux-i2c, linux-kernel Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/i2c-sprd.c @@ -627,6 +627,7 @@ static const struct dev_pm_ops sprd_i2c_ static const struct of_device_id sprd_i2c_of_match[] = { { .compatible = "sprd,sc9860-i2c", }, + {}, }; static struct platform_driver sprd_i2c_driver = { ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] i2c: Cocci spatch "of_table" 2017-09-21 6:24 ` [PATCH 2/3] i2c: Cocci spatch "of_table" Thomas Meyer @ 2017-10-05 11:26 ` Wolfram Sang 0 siblings, 0 replies; 6+ messages in thread From: Wolfram Sang @ 2017-10-05 11:26 UTC (permalink / raw) To: Thomas Meyer; +Cc: linux-i2c, linux-kernel [-- Attachment #1: Type: text/plain, Size: 377 bytes --] On Thu, Sep 21, 2017 at 08:24:27AM +0200, Thomas Meyer wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated. > Found by coccinelle spatch "misc/of_table.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Applied to for-current, thanks! But please use descriptive subjects, I cahanged it to "i2c: ensure termination of *_device_id tables" [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] ARM: mediatek: Cocci spatch "of_table" 2017-09-21 6:24 [PATCH 0/3] Cocci spatch "of_table" - v4.14-rc1 Thomas Meyer 2017-09-21 6:24 ` [PATCH 2/3] i2c: Cocci spatch "of_table" Thomas Meyer @ 2017-09-21 6:24 ` Thomas Meyer 2017-10-13 14:57 ` Matthias Brugger 2017-09-21 6:24 ` [PATCH 3/3] net: stmmac: " Thomas Meyer 2 siblings, 1 reply; 6+ messages in thread From: Thomas Meyer @ 2017-09-21 6:24 UTC (permalink / raw) To: matthias.bgg, linux, linux-arm-kernel, linux-mediatek, linux-kernel Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c --- a/arch/arm/mach-mediatek/platsmp.c +++ b/arch/arm/mach-mediatek/platsmp.c @@ -54,12 +54,14 @@ static const struct of_device_id mtk_tz_ { .compatible = "mediatek,mt8135", .data = &mtk_mt8135_tz_boot }, { .compatible = "mediatek,mt8127", .data = &mtk_mt8135_tz_boot }, { .compatible = "mediatek,mt2701", .data = &mtk_mt8135_tz_boot }, + {}, }; static const struct of_device_id mtk_smp_boot_infos[] __initconst = { { .compatible = "mediatek,mt6589", .data = &mtk_mt6589_boot }, { .compatible = "mediatek,mt7623", .data = &mtk_mt7623_boot }, { .compatible = "mediatek,mt7623a", .data = &mtk_mt7623_boot }, + {}, }; static void __iomem *mtk_smp_base; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] ARM: mediatek: Cocci spatch "of_table" 2017-09-21 6:24 ` [PATCH 1/3] ARM: mediatek: " Thomas Meyer @ 2017-10-13 14:57 ` Matthias Brugger 0 siblings, 0 replies; 6+ messages in thread From: Matthias Brugger @ 2017-10-13 14:57 UTC (permalink / raw) To: Thomas Meyer, linux, linux-arm-kernel, linux-mediatek, linux-kernel On 09/21/2017 08:24 AM, Thomas Meyer wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated. > Found by coccinelle spatch "misc/of_table.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- > Applied to v4.14-next/soc Thanks! > diff -u -p a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c > --- a/arch/arm/mach-mediatek/platsmp.c > +++ b/arch/arm/mach-mediatek/platsmp.c > @@ -54,12 +54,14 @@ static const struct of_device_id mtk_tz_ > { .compatible = "mediatek,mt8135", .data = &mtk_mt8135_tz_boot }, > { .compatible = "mediatek,mt8127", .data = &mtk_mt8135_tz_boot }, > { .compatible = "mediatek,mt2701", .data = &mtk_mt8135_tz_boot }, > + {}, > }; > > static const struct of_device_id mtk_smp_boot_infos[] __initconst = { > { .compatible = "mediatek,mt6589", .data = &mtk_mt6589_boot }, > { .compatible = "mediatek,mt7623", .data = &mtk_mt7623_boot }, > { .compatible = "mediatek,mt7623a", .data = &mtk_mt7623_boot }, > + {}, > }; > > static void __iomem *mtk_smp_base; > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] net: stmmac: Cocci spatch "of_table" 2017-09-21 6:24 [PATCH 0/3] Cocci spatch "of_table" - v4.14-rc1 Thomas Meyer 2017-09-21 6:24 ` [PATCH 2/3] i2c: Cocci spatch "of_table" Thomas Meyer 2017-09-21 6:24 ` [PATCH 1/3] ARM: mediatek: " Thomas Meyer @ 2017-09-21 6:24 ` Thomas Meyer 2 siblings, 0 replies; 6+ messages in thread From: Thomas Meyer @ 2017-09-21 6:24 UTC (permalink / raw) To: peppe.cavallaro, alexandre.torgue, netdev, linux-kernel Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -315,6 +315,7 @@ static int stmmac_dt_phy(struct plat_stm { .compatible = "allwinner,sun8i-h3-emac" }, { .compatible = "allwinner,sun8i-v3s-emac" }, { .compatible = "allwinner,sun50i-a64-emac" }, + {}, }; /* If phy-handle property is passed from DT, use it as the PHY */ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-13 14:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-21 6:24 [PATCH 0/3] Cocci spatch "of_table" - v4.14-rc1 Thomas Meyer 2017-09-21 6:24 ` [PATCH 2/3] i2c: Cocci spatch "of_table" Thomas Meyer 2017-10-05 11:26 ` Wolfram Sang 2017-09-21 6:24 ` [PATCH 1/3] ARM: mediatek: " Thomas Meyer 2017-10-13 14:57 ` Matthias Brugger 2017-09-21 6:24 ` [PATCH 3/3] net: stmmac: " Thomas Meyer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®