* [PATCH] drm/rockchip: add PINCTRL dependency for LVDS
@ 2017-10-05 12:09 Arnd Bergmann
2017-10-13 2:28 ` Mark yao
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-10-05 12:09 UTC (permalink / raw)
To: Mark Yao, David Airlie, Heiko Stuebner
Cc: Arnd Bergmann, Sean Paul, Guenter Roeck, Sandy Huang,
Chris Zhong, Jeffy Chen, dri-devel, linux-arm-kernel,
linux-rockchip, linux-kernel
The new driver fails to build when CONFIG_PINCTRL is disabled:
drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config':
drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct dev_pin_info'
if (lvds->pins && !IS_ERR(lvds->pins->default_state))
This adds the respective Kconfig dependency.
Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 0c31f0a27b9c..3c70c6224bd2 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -60,6 +60,7 @@ config ROCKCHIP_INNO_HDMI
config ROCKCHIP_LVDS
bool "Rockchip LVDS support"
depends on DRM_ROCKCHIP
+ depends on PINCTRL
help
Choose this option to enable support for Rockchip LVDS controllers.
Rockchip rk3288 SoC has LVDS TX Controller can be used, and it
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/rockchip: add PINCTRL dependency for LVDS
2017-10-05 12:09 [PATCH] drm/rockchip: add PINCTRL dependency for LVDS Arnd Bergmann
@ 2017-10-13 2:28 ` Mark yao
0 siblings, 0 replies; 2+ messages in thread
From: Mark yao @ 2017-10-13 2:28 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie, Heiko Stuebner
Cc: linux-rockchip, Jeffy Chen, Sandy Huang, dri-devel, linux-kernel,
Chris Zhong, Sean Paul, Guenter Roeck, linux-arm-kernel
On 2017年10月05日 20:09, Arnd Bergmann wrote:
> The new driver fails to build when CONFIG_PINCTRL is disabled:
>
> drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config':
> drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct dev_pin_info'
> if (lvds->pins && !IS_ERR(lvds->pins->default_state))
>
> This adds the respective Kconfig dependency.
>
> Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Pushed to drm-misc-next
Thanks
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 2:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 12:09 [PATCH] drm/rockchip: add PINCTRL dependency for LVDS Arnd Bergmann
2017-10-13 2:28 ` Mark yao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®