mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"chanwoo@kernel.org" <chanwoo@kernel.org>,
	Inki Dae <inki.dae@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: FW: RE: [PATCH v3 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device
Date: Wed, 11 Oct 2017 11:22:18 +0000	[thread overview]
Message-ID: <20171011112218epcms1p44a92995d11f8bed42199eab623b4a2d1@epcms1p4> (raw)
In-Reply-To: <20171011110952epcms1p2f1c04c3cc0b078c07b55e7031cd175ac@epcms1p2>

> > Prior to that, the min/max_freq of the devfreq device are always zero
> > before the user changes the min/max_freq through sysfs entries.
> > It might make the confusion for the min/max_freq.
> > 
> > This patch initializes the available min/max_freq by using the OPP
> > during adding the devfreq device.
> > 
> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> > ---
> >  drivers/devfreq/devfreq.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> > 
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index a1c4ee818614..ae8717a6eee1 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index a1c4ee818614..ae8717a6eee1 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -69,6 +69,34 @@ static struct devfreq *find_device_devfreq(struct device *dev)
> >  	return ERR_PTR(-ENODEV);
> >  }
> >  
> > +static unsigned long find_available_min_freq(struct devfreq *devfreq)
> > +{
> > +	struct dev_pm_opp *opp;
> > +	unsigned long min_freq = 0;
> > +
> > +	opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &min_freq);
> 
> When min_freq is 0, dev_pm_opp_find_freq_ceil will return ERR_PTR(-EINVAL);
> 
> --- from drivers/base/power/opp/core.c ------ 
> struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev,
>                                              unsigned long *freq)
> {
>         struct opp_table *opp_table;
>         struct dev_pm_opp *opp;
> 
>         if (!dev || !freq) {
>                 dev_err(dev, "%s: Invalid argument freq=%p\n", __func__, freq);
>                 return ERR_PTR(-EINVAL);
>         }
> ---------------------------------------------

Sorry, please never mind. My Bad. Your code had no such issues.

So, I'm adding:
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> 
> Cheers,
> MyungJoo
> 

  parent reply	other threads:[~2017-10-11 11:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171011030946epcas1p1268ea2af497086ca64c373ea7367baaa@epcas1p1.samsung.com>
2017-10-11  3:09 ` [PATCH v3 0/8] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
     [not found]   ` <CGME20171011030946epcas1p156d133af4c065453eb8afde9e0e6869d@epcas1p1.samsung.com>
2017-10-11  3:09     ` [PATCH v3 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device Chanwoo Choi
     [not found]   ` <CGME20171011030946epcas1p11592eaf29e9b9717ccf7a8965d8e2286@epcas1p1.samsung.com>
2017-10-11  3:09     ` [PATCH v3 2/8] Revert "PM / devfreq: Add show_one macro to delete the duplicate code" Chanwoo Choi
     [not found]   ` <CGME20171011030946epcas1p40f32955da5dada46e95302701a0afb7d@epcas1p4.samsung.com>
2017-10-11  3:09     ` [PATCH v3 3/8] PM / devfreq: Show the available min/max frequency through sysfs node Chanwoo Choi
     [not found]   ` <CGME20171011030946epcas1p30ca5f54e1dd4df92cefd19a385423a41@epcas1p3.samsung.com>
2017-10-11  3:09     ` [PATCH v3 4/8] PM / devfreq: Show the all available frequencies Chanwoo Choi
     [not found]   ` <CGME20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b@epcas1p1.samsung.com>
2017-10-11  3:09     ` [PATCH v3 5/8] PM / devfreq: Get the available next frequency on update_devfreq() Chanwoo Choi
     [not found]   ` <CGME20171011030947epcas1p3172d6bb79615a17e08164a150031262e@epcas1p3.samsung.com>
2017-10-11  3:09     ` [PATCH v3 6/8] PM / devfreq: Remove unneeded conditional statement Chanwoo Choi
     [not found]   ` <CGME20171011030947epcas1p3fead28d00a52590b344b728dfca59138@epcas1p3.samsung.com>
2017-10-11  3:09     ` [PATCH v3 7/8] PM / devfreq: Define the constant governor name Chanwoo Choi
     [not found]   ` <CGME20171011030947epcas1p475944e5d83cf28deaa3cdef731315d63@epcas1p4.samsung.com>
2017-10-11  3:09     ` [PATCH v3 8/8] PM / devfreq: exynos-bus: Register cooling device Chanwoo Choi
     [not found]   ` <CGME20171011030946epcas1p156d133af4c065453eb8afde9e0e6869d@epcms1p2>
2017-10-11 11:09     ` [PATCH v3 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device MyungJoo Ham
     [not found]   ` <CGME20171011030946epcas1p40f32955da5dada46e95302701a0afb7d@epcms1p3>
2017-10-11 11:15     ` [PATCH v3 3/8] PM / devfreq: Show the available min/max frequency through sysfs node MyungJoo Ham
2017-10-11 12:57       ` Chanwoo Choi
2017-10-12  4:08         ` Chanwoo Choi
2017-10-13  6:47           ` Chanwoo Choi
     [not found]   ` <CGME20171011030946epcas1p156d133af4c065453eb8afde9e0e6869d@epcms1p4>
2017-10-11 11:22     ` MyungJoo Ham [this message]
     [not found]   ` <CGME20171011030946epcas1p30ca5f54e1dd4df92cefd19a385423a41@epcms1p4>
2017-10-11 11:26     ` [PATCH v3 4/8] PM / devfreq: Show the all available frequencies MyungJoo Ham
2017-10-11 13:14       ` Chanwoo Choi
     [not found]   ` <CGME20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b@epcms1p2>
2017-10-11 11:30     ` [PATCH v3 5/8] PM / devfreq: Get the available next frequency on update_devfreq() MyungJoo Ham
2017-10-11 13:33       ` Chanwoo Choi
2017-10-13  6:45         ` Chanwoo Choi
     [not found]   ` <CGME20171011030947epcas1p3172d6bb79615a17e08164a150031262e@epcms1p5>
2017-10-11 11:36     ` [PATCH v3 6/8] PM / devfreq: Remove unneeded conditional statement MyungJoo Ham
2017-10-11 13:45       ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011112218epcms1p44a92995d11f8bed42199eab623b4a2d1@epcms1p4 \
    --to=myungjoo.ham@samsung.com \
    --cc=chanwoo@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®