From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Cc: "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"chanwoo@kernel.org" <chanwoo@kernel.org>,
Inki Dae <inki.dae@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH v3 5/8] PM / devfreq: Get the available next frequency on update_devfreq()
Date: Wed, 11 Oct 2017 11:30:41 +0000 [thread overview]
Message-ID: <20171011113041epcms1p2c09f39f5db8f3b33cb25fe4c28e18e74@epcms1p2> (raw)
In-Reply-To: <1507691364-3899-6-git-send-email-cw00.choi@samsung.com>
> The update_devfreq() considers only user frequency (min_freq/max_freq)
> and the next target_freq provided by the governor. But, the commit
> a76caf55e5b35 ("thermal: Add devfreq cooling") is able to disable
> OPP as a cooling device. In result, the update_devfreq() have to
> consider the 'opp->available' status in order to decicde the next freq
> by the devfreq_recommended_opp().
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> drivers/devfreq/devfreq.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1c4b377cacfb..3b9662ffe603 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -255,6 +255,7 @@ static int devfreq_notify_transition(struct devfreq *devfreq,
> int update_devfreq(struct devfreq *devfreq)
> {
> struct devfreq_freqs freqs;
> + struct dev_pm_opp *opp;
> unsigned long freq, cur_freq;
> int err = 0;
> u32 flags = 0;
> @@ -273,7 +274,7 @@ int update_devfreq(struct devfreq *devfreq)
> return err;
>
> /*
> - * Adjust the frequency with user freq and QoS.
> + * Adjust the frequency with user freq, QoS and available freq.
> *
> * List from the highest priority
> * max_freq
> @@ -289,6 +290,12 @@ int update_devfreq(struct devfreq *devfreq)
> flags |= DEVFREQ_FLAG_LEAST_UPPER_BOUND; /* Use LUB */
> }
>
> + opp = devfreq_recommended_opp(devfreq->dev.parent, &freq, flags);
> + if (IS_ERR(opp))
> + return PTR_ERR(opp);
> + freq = dev_pm_opp_get_freq(opp);
> + dev_pm_opp_put(opp);
> +
Is this really necessary?
devfreq_recommended_opp is going to be called by the device driver
invoked by devfreq->profile->target() function anyway.
We are now going to call devfreq_recommended_opp twice in this context.
> if (devfreq->profile->get_cur_freq)
> devfreq->profile->get_cur_freq(devfreq->dev.parent, &cur_freq);
> else
> --
next prev parent reply other threads:[~2017-10-11 11:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171011030946epcas1p1268ea2af497086ca64c373ea7367baaa@epcas1p1.samsung.com>
2017-10-11 3:09 ` [PATCH v3 0/8] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
[not found] ` <CGME20171011030946epcas1p156d133af4c065453eb8afde9e0e6869d@epcas1p1.samsung.com>
2017-10-11 3:09 ` [PATCH v3 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device Chanwoo Choi
[not found] ` <CGME20171011030946epcas1p11592eaf29e9b9717ccf7a8965d8e2286@epcas1p1.samsung.com>
2017-10-11 3:09 ` [PATCH v3 2/8] Revert "PM / devfreq: Add show_one macro to delete the duplicate code" Chanwoo Choi
[not found] ` <CGME20171011030946epcas1p40f32955da5dada46e95302701a0afb7d@epcas1p4.samsung.com>
2017-10-11 3:09 ` [PATCH v3 3/8] PM / devfreq: Show the available min/max frequency through sysfs node Chanwoo Choi
[not found] ` <CGME20171011030946epcas1p30ca5f54e1dd4df92cefd19a385423a41@epcas1p3.samsung.com>
2017-10-11 3:09 ` [PATCH v3 4/8] PM / devfreq: Show the all available frequencies Chanwoo Choi
[not found] ` <CGME20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b@epcas1p1.samsung.com>
2017-10-11 3:09 ` [PATCH v3 5/8] PM / devfreq: Get the available next frequency on update_devfreq() Chanwoo Choi
[not found] ` <CGME20171011030947epcas1p3172d6bb79615a17e08164a150031262e@epcas1p3.samsung.com>
2017-10-11 3:09 ` [PATCH v3 6/8] PM / devfreq: Remove unneeded conditional statement Chanwoo Choi
[not found] ` <CGME20171011030947epcas1p3fead28d00a52590b344b728dfca59138@epcas1p3.samsung.com>
2017-10-11 3:09 ` [PATCH v3 7/8] PM / devfreq: Define the constant governor name Chanwoo Choi
[not found] ` <CGME20171011030947epcas1p475944e5d83cf28deaa3cdef731315d63@epcas1p4.samsung.com>
2017-10-11 3:09 ` [PATCH v3 8/8] PM / devfreq: exynos-bus: Register cooling device Chanwoo Choi
[not found] ` <CGME20171011030946epcas1p156d133af4c065453eb8afde9e0e6869d@epcms1p2>
2017-10-11 11:09 ` [PATCH v3 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device MyungJoo Ham
[not found] ` <CGME20171011030946epcas1p40f32955da5dada46e95302701a0afb7d@epcms1p3>
2017-10-11 11:15 ` [PATCH v3 3/8] PM / devfreq: Show the available min/max frequency through sysfs node MyungJoo Ham
2017-10-11 12:57 ` Chanwoo Choi
2017-10-12 4:08 ` Chanwoo Choi
2017-10-13 6:47 ` Chanwoo Choi
[not found] ` <CGME20171011030946epcas1p156d133af4c065453eb8afde9e0e6869d@epcms1p4>
2017-10-11 11:22 ` FW: RE: [PATCH v3 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device MyungJoo Ham
[not found] ` <CGME20171011030946epcas1p30ca5f54e1dd4df92cefd19a385423a41@epcms1p4>
2017-10-11 11:26 ` [PATCH v3 4/8] PM / devfreq: Show the all available frequencies MyungJoo Ham
2017-10-11 13:14 ` Chanwoo Choi
[not found] ` <CGME20171011030947epcas1p1133ca20bb9356453c331751b3e3bba4b@epcms1p2>
2017-10-11 11:30 ` MyungJoo Ham [this message]
2017-10-11 13:33 ` [PATCH v3 5/8] PM / devfreq: Get the available next frequency on update_devfreq() Chanwoo Choi
2017-10-13 6:45 ` Chanwoo Choi
[not found] ` <CGME20171011030947epcas1p3172d6bb79615a17e08164a150031262e@epcms1p5>
2017-10-11 11:36 ` [PATCH v3 6/8] PM / devfreq: Remove unneeded conditional statement MyungJoo Ham
2017-10-11 13:45 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011113041epcms1p2c09f39f5db8f3b33cb25fe4c28e18e74@epcms1p2 \
--to=myungjoo.ham@samsung.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®