From: Michal Hocko <mhocko@kernel.org>
To: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"vegardno@ifi.uio.no" <vegardno@ifi.uio.no>,
"penberg@kernel.org" <penberg@kernel.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"glider@google.com" <glider@google.com>,
"devtimhansen@gmail.com" <devtimhansen@gmail.com>
Subject: Re: [PATCH v2 1/4] kmemcheck: remove annotations
Date: Wed, 11 Oct 2017 15:17:32 +0200 [thread overview]
Message-ID: <20171011131732.kfx53yvgfqbufiqi@dhcp22.suse.cz> (raw)
In-Reply-To: <20171007030159.22241-2-alexander.levin@verizon.com>
On Sat 07-10-17 03:02:13, Sasha Levin wrote:
> Remove kmemcheck annotations, and calls to kmemcheck from the kernel.
How did you generate this? I suspect a git grep + sed? Because this
doesn't seem to be correct. I didn't get further than this
> @@ -266,7 +264,6 @@ static inline int dma_map_sg_attrs(struct device *dev, struct scatterlist *sg,
> struct scatterlist *s;
>
> for_each_sg(sg, s, nents, i)
> - kmemcheck_mark_initialized(sg_virt(s), s->length);
> BUG_ON(!valid_dma_direction(dir));
> ents = ops->map_sg(dev, sg, nents, dir, attrs);
> BUG_ON(ents < 0);
which doesn't really look correct. I appreciate you have split this up
and the resulting code might even be correct I find it quite important
to have such a large changes be reproducible by reviewers because it is
simply impossible to review this manually.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-10-11 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 3:02 [PATCH v2 0/4] kmemcheck: kill kmemcheck Levin, Alexander (Sasha Levin)
2017-10-07 3:02 ` [PATCH v2 1/4] kmemcheck: remove annotations Levin, Alexander (Sasha Levin)
2017-10-11 13:17 ` Michal Hocko [this message]
2017-10-11 14:07 ` Levin, Alexander (Sasha Levin)
2017-10-07 3:02 ` [PATCH v2 2/4] kmemcheck: stop using GFP_NOTRACK and SLAB_NOTRACK Levin, Alexander (Sasha Levin)
2017-10-07 3:02 ` [PATCH v2 3/4] kmemcheck: rip it out Levin, Alexander (Sasha Levin)
2017-10-07 3:02 ` [PATCH v2 4/4] kmemcheck: remove whats left of NOTRACK flags Levin, Alexander (Sasha Levin)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011131732.kfx53yvgfqbufiqi@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@verizon.com \
--cc=devtimhansen@gmail.com \
--cc=ebiederm@xmission.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vegardno@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®