From: "J. Bruce Fields" <bfields@fieldses.org>
To: David Howells <dhowells@redhat.com>
Cc: Jia-Ju Bai <baijiaju1990@163.com>,
Jeff Layton <jlayton@redhat.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/afs/flock and fs/locks: Fix possible sleep-in-atomic bugs in posix_lock_file
Date: Wed, 11 Oct 2017 09:45:00 -0400 [thread overview]
Message-ID: <20171011134500.GB25913@fieldses.org> (raw)
In-Reply-To: <17920.1507715263@warthog.procyon.org.uk>
On Wed, Oct 11, 2017 at 10:47:43AM +0100, David Howells wrote:
> J. Bruce Fields <bfields@fieldses.org> wrote:
>
> > Does that mean nobody's tested fcntl locking over afs since that change in
> > 2010?
>
> Quite feasibly not. I've been beating kAFS into shape and I'm aware of the
> lock thing. It's on the list after getting the core server rotation working
> properly since that will affect a whole bunch of code, including the locking
> code.
>
> I've more or less finished the server rotation bit. See:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-2-experimental
Neat!
Well, pending a real fix I suppose it's probably clearest to leave the
locking code in an obviously broken state. Might be worth a comment
though.
--b.
prev parent reply other threads:[~2017-10-11 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 9:55 Jia-Ju Bai
2017-10-07 10:36 ` Jeff Layton
2017-10-08 1:07 ` J. Bruce Fields
2017-10-11 9:47 ` David Howells
2017-10-11 13:45 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011134500.GB25913@fieldses.org \
--to=bfields@fieldses.org \
--cc=baijiaju1990@163.com \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®