mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH] tracing/xen: Hide events that are not used when X86_PAE is not defined
Date: Wed, 11 Oct 2017 21:05:42 -0400	[thread overview]
Message-ID: <20171011210542.6ac512e7@gandalf.local.home> (raw)
In-Reply-To: <bf4f50a7-4d31-ebdf-f946-ab3e61e59c8e@arm.com>

On Wed, 11 Oct 2017 19:39:20 -0500
Jeremy Linton <jeremy.linton@arm.com> wrote:

> On 10/10/2017 06:12 PM, Steven Rostedt wrote:
> > From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > 
> > TRACE_EVENTS() take up memory. If they are defined but not used, then
> > they simply waste space. If their use case is behind a define, then the
> > trace events should be as well.
> > 
> > The trace events xen_mmu_set_pte_atomic, xen_mmu_pte_clear, and
> > xen_mmu_pmd_clear are not used when CONFIG_X86_PAE is not defined.  
> 
> The only place i see them being used is mmu_pv.c, where they are wrapped 
> in the stated #define.
> 
> Looks good.
> 
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
> 

Thanks Jeremy,

-- Steve

      reply	other threads:[~2017-10-12  1:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 23:12 Steven Rostedt
2017-10-10 23:25 ` Boris Ostrovsky
2017-10-12  1:05   ` Steven Rostedt
2017-10-12  0:39 ` Jeremy Linton
2017-10-12  1:05   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011210542.6ac512e7@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jeremy.linton@arm.com \
    --cc=jgross@suse.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®