From: Omar Sandoval <osandov@osandov.com>
To: Christos Gkekas <chris.gekas@gmail.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: Clean up unused variables in free-space-tree.c
Date: Thu, 12 Oct 2017 14:43:27 -0700 [thread overview]
Message-ID: <20171012214327.GA16154@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <1507844442-26013-1-git-send-email-chris.gekas@gmail.com>
On Thu, Oct 12, 2017 at 10:40:42PM +0100, Christos Gkekas wrote:
> Remove variables 'start' and 'end', which are set but never used.
Oops.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> fs/btrfs/free-space-tree.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c
> index 684f122..fe5e032 100644
> --- a/fs/btrfs/free-space-tree.c
> +++ b/fs/btrfs/free-space-tree.c
> @@ -1286,12 +1286,8 @@ static int __add_block_group_free_space(struct btrfs_trans_handle *trans,
> struct btrfs_block_group_cache *block_group,
> struct btrfs_path *path)
> {
> - u64 start, end;
> int ret;
>
> - start = block_group->key.objectid;
> - end = block_group->key.objectid + block_group->key.offset;
> -
> block_group->needs_free_space = 0;
>
> ret = add_new_free_space_info(trans, fs_info, block_group, path);
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-10-12 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 21:40 Christos Gkekas
2017-10-12 21:43 ` Omar Sandoval [this message]
2017-10-13 12:08 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012214327.GA16154@vader.DHCP.thefacebook.com \
--to=osandov@osandov.com \
--cc=chris.gekas@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®