Re: [PATCH 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation

[Lee Jones <lee.jones@linaro.org>]

On Fri, 13 Oct 2017, Baolin Wang wrote:
> On 13 October 2017 at 17:07, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 11 Oct 2017, Baolin Wang wrote:
> >
> >> This patch adds the binding documentation for Spreadtrum SC27xx series
> >> PMIC device.
> >>
> >> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> >> ---
> >>  .../devicetree/bindings/mfd/sprd,sc27xx-pmic.txt   |   23 ++++++++++++++++++++
> >>  1 file changed, 23 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt b/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt
> >> new file mode 100644
> >> index 0000000..333c818
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt
> >> @@ -0,0 +1,23 @@
> >> +Spreadtrum SC27xx Power Management Integrated Circuit (PMIC)
> >
> > More info please.
> >
> > What does the ship do and what other devices are available.
> 
> OK. I will add more information in next version.
> 
> >
> >> +Required properties:
> >> +- compatible: Should be "sprd,sc2731".
> >> +- reg: SPI chip select.
> >
> > Really?  Not an address?
> 
> Yes, it should be device address.
> 
> >
> > What is the range?
> >
> >> +- spi-max-frequency: Typically set to 26000000.
> >> +- interrupts: The interrupt line the device is connected to.
> >> +- interrupt-controller: Marks the device node as an interrupt controller.
> >> +- #interrupt-cells: The number of cells to describe an PMIC IRQ, should be 2.
> >
> > What if it's not 2?  Will it still work?
> 
> Must be 2, if not it can not work well. Will update in next version.
> 
> >
> >> +- #address-cells: Child device offset number of cells, should be 1.
> >
> > Same.
> 
> OK.
> 
> >
> >> +- #size-cells: Child device size number of cells, should be 0.
> >
> > Same.
> 
> OK.
> 
> >
> >> +
> >> +Example:
> >> +pmic: pmic@0 {
> >
> > What other nodes are you referencing this one from?
> 
> This node should be under our ADI/SPI master device node, as one SPI
> device. I will add the SPI master node in next version. Very
> appreciated for your comments.

Sorry, what I'm getting at is; is the 'pmic:' label really required?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog