* [PATCH] tracing, mei: Remove unused trace event mei_pci_cfg_write
@ 2017-10-13 13:58 Steven Rostedt
2017-10-16 14:24 ` Winkler, Tomas
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2017-10-13 13:58 UTC (permalink / raw)
To: LKML; +Cc: Tomas Winkler, Greg Kroah-Hartman, Andrew Morton
From: Steven Rostedt (VMware) <rostedt@goodmis.org>
Commit a96c548291 ("mei: trace pci configuration space io") added the
trace event mei_pci_cfg_write but never used it. As trace events that
are defined take up space for data structures and functions created for
them, it is a waste of memory to have one defined but not used. Remove
this trace event.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
Index: linux-trace.git/drivers/misc/mei/mei-trace.h
===================================================================
--- linux-trace.git.orig/drivers/misc/mei/mei-trace.h
+++ linux-trace.git/drivers/misc/mei/mei-trace.h
@@ -83,25 +83,6 @@ TRACE_EVENT(mei_pci_cfg_read,
__get_str(dev), __entry->reg, __entry->offs, __entry->val)
);
-TRACE_EVENT(mei_pci_cfg_write,
- TP_PROTO(const struct device *dev, const char *reg, u32 offs, u32 val),
- TP_ARGS(dev, reg, offs, val),
- TP_STRUCT__entry(
- __string(dev, dev_name(dev))
- __field(const char *, reg)
- __field(u32, offs)
- __field(u32, val)
- ),
- TP_fast_assign(
- __assign_str(dev, dev_name(dev))
- __entry->reg = reg;
- __entry->offs = offs;
- __entry->val = val;
- ),
- TP_printk("[%s] pci cfg write %s[%#x] = %#x",
- __get_str(dev), __entry->reg, __entry->offs, __entry->val)
-);
-
#endif /* _MEI_TRACE_H_ */
/* This part must be outside protection */
Index: linux-trace.git/drivers/misc/mei/mei-trace.c
===================================================================
--- linux-trace.git.orig/drivers/misc/mei/mei-trace.c
+++ linux-trace.git/drivers/misc/mei/mei-trace.c
@@ -23,5 +23,4 @@
EXPORT_TRACEPOINT_SYMBOL(mei_reg_read);
EXPORT_TRACEPOINT_SYMBOL(mei_reg_write);
EXPORT_TRACEPOINT_SYMBOL(mei_pci_cfg_read);
-EXPORT_TRACEPOINT_SYMBOL(mei_pci_cfg_write);
#endif /* __CHECKER__ */
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] tracing, mei: Remove unused trace event mei_pci_cfg_write
2017-10-13 13:58 [PATCH] tracing, mei: Remove unused trace event mei_pci_cfg_write Steven Rostedt
@ 2017-10-16 14:24 ` Winkler, Tomas
0 siblings, 0 replies; 2+ messages in thread
From: Winkler, Tomas @ 2017-10-16 14:24 UTC (permalink / raw)
To: Steven Rostedt, LKML; +Cc: Greg Kroah-Hartman, Andrew Morton
> Subject: [PATCH] tracing, mei: Remove unused trace event mei_pci_cfg_write
>
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Commit a96c548291 ("mei: trace pci configuration space io") added the trace
> event mei_pci_cfg_write but never used it. As trace events that are defined
> take up space for data structures and functions created for them, it is a
> waste of memory to have one defined but not used. Remove this trace
> event.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Ok, really not used.
Tomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 13:58 [PATCH] tracing, mei: Remove unused trace event mei_pci_cfg_write Steven Rostedt
2017-10-16 14:24 ` Winkler, Tomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®