From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tracing, memcg, vmscan: Hide trace events when not in use
Date: Fri, 13 Oct 2017 10:28:48 -0400 [thread overview]
Message-ID: <20171013102848.34dec4a7@gandalf.local.home> (raw)
In-Reply-To: <20171013063826.6likzbzmfz6fojl2@dhcp22.suse.cz>
On Fri, 13 Oct 2017 08:38:26 +0200
Michal Hocko <mhocko@kernel.org> wrote:
> I do not understand the ftrace machinery
Not many do :-/
> and I have to admit I was under
> impression that nothing really gets defined if the code using them
> doesn't exist but if this is not the case then this patch makes sense to
> me
Sometimes events are created by kernel proper that are used by modules,
or created by modules to be used by other modules (kvm does this with
kvm_intel and kvm_amd). Unfortunately, for these cases they need to
stay. Or later, I plan on moving them to where they are used, because
they have the same issue (wasting memory).
>
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
-- Steve
prev parent reply other threads:[~2017-10-13 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:46 Steven Rostedt
2017-10-13 6:38 ` Michal Hocko
2017-10-13 14:28 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013102848.34dec4a7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®