From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg_attrs
Date: Fri, 13 Oct 2017 14:05:35 +0000 [thread overview]
Message-ID: <20171013140532.ro55tfh4yagk5cc6@sasha-lappy> (raw)
In-Reply-To: <20171013071121.4v73j7gn472ezv23@dhcp22.suse.cz>
On Fri, Oct 13, 2017 at 09:11:21AM +0200, Michal Hocko wrote:
>On Thu 12-10-17 19:22:05, Sasha Levin wrote:
>> We have missed removing some code as part of removing the kmemcheck
>> hooks.
>>
>> Unfourtenatly this got missed during my review, and the code was
>> still building.
>>
>> Reported-by: Michal Hocko <mhocko@kernel.org>
>> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
>
>Yes this would be the proper fix for the specific issue I have noticed.
>There might be others I haven't even checked. Really the only way to
>make this chage is to post a reproducible steps to regenerate your diff
>and review that the used scripts are correct. Follow up fixes are not a
>way to go
So the only part of this series that was scripted to some extend was
this commit we're looking at. The 3 other commits are done manually
(although their large size is mostly attributed to 'git rm').
Even for this commit, I don't see a way to have it completely scripted
given that we're not simply removing calls.
I've looked at the ~50 deletions of kmemcheck calls in this commit to
make sure they make sense.
--
Thanks,
Sasha
prev parent reply other threads:[~2017-10-13 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 19:22 Levin, Alexander (Sasha Levin)
2017-10-13 7:11 ` Michal Hocko
2017-10-13 14:05 ` Levin, Alexander (Sasha Levin) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013140532.ro55tfh4yagk5cc6@sasha-lappy \
--to=alexander.levin@verizon.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®