From: Javi Merino <javi.merino@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>
Subject: Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use
Date: Tue, 17 Oct 2017 08:16:59 +0100 [thread overview]
Message-ID: <20171017071659.57q4tcrg2mrochjn@tesla> (raw)
In-Reply-To: <20171013102309.2c4ef81a@gandalf.local.home>
On Fri, Oct 13, 2017 at 10:23:09AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> As trace events when defined create data structures and functions to
> process them, defining trace events when not using them is a waste of
> memory.
>
> The trace events thermal_power_cpu_get_power and
> thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set.
> Make those events only defined when that is set as well.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Javi Merino <javi.merino@kernel.org>
> ---
> Index: linux-trace.git/include/trace/events/thermal.h
> ===================================================================
> --- linux-trace.git.orig/include/trace/events/thermal.h
> +++ linux-trace.git/include/trace/events/thermal.h
> @@ -90,6 +90,7 @@ TRACE_EVENT(thermal_zone_trip,
> show_tzt_type(__entry->trip_type))
> );
>
> +#ifdef CONFIG_CPU_THERMAL
> TRACE_EVENT(thermal_power_cpu_get_power,
> TP_PROTO(const struct cpumask *cpus, unsigned long freq, u32 *load,
> size_t load_len, u32 dynamic_power, u32 static_power),
> @@ -147,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit,
> __get_bitmask(cpumask), __entry->freq, __entry->cdev_state,
> __entry->power)
> );
> +#endif /* CONFIG_CPU_THERMAL */
>
> #ifdef CONFIG_DEVFREQ_THERMAL
> TRACE_EVENT(thermal_power_devfreq_get_power,
prev parent reply other threads:[~2017-10-17 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 14:19 [PATCH 0/2] tracing, thermal: Hide " Steven Rostedt
2017-10-13 14:21 ` [PATCH 1/2] tracing, thermal: Hide devfreq " Steven Rostedt
2017-10-17 7:15 ` Javi Merino
2017-10-13 14:23 ` [PATCH 2/2] tracing, thermal: Hide cpu cooling " Steven Rostedt
2017-10-17 7:16 ` Javi Merino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017071659.57q4tcrg2mrochjn@tesla \
--to=javi.merino@kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®