mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH RESEND] perf record: Fix documentation for a disused option '-l'
@ 2017-10-13 15:10 Taeung Song
  2017-10-17 12:06 ` Arnaldo Carvalho de Melo
  2017-10-20  7:20 ` [tip:perf/urgent] perf record: Fix documentation for a inexistent " tip-bot for Taeung Song
  0 siblings, 2 replies; 3+ messages in thread
From: Taeung Song @ 2017-10-13 15:10 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: linux-kernel, taeung, Jiri Olsa, Namhyung Kim

perf-record had a '-l' option that mean "scale counter values"
very long time ago, but it currently belong to perf-stat as '-c'.
So remove it. I found this problem in the below case.

    $ perf record -e cycles -l sleep 3
      Error: unknown switch `l

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/Documentation/perf-record.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index 68a1ffb..5a626ef 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -8,8 +8,8 @@ perf-record - Run a command and record its profile into perf.data
 SYNOPSIS
 --------
 [verse]
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] <command>
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] -- <command> [<options>]
+'perf record' [-e <EVENT> | --event=EVENT] [-a] <command>
+'perf record' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
 
 DESCRIPTION
 -----------
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] perf record: Fix documentation for a disused option '-l'
  2017-10-13 15:10 [PATCH RESEND] perf record: Fix documentation for a disused option '-l' Taeung Song
@ 2017-10-17 12:06 ` Arnaldo Carvalho de Melo
  2017-10-20  7:20 ` [tip:perf/urgent] perf record: Fix documentation for a inexistent " tip-bot for Taeung Song
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-10-17 12:06 UTC (permalink / raw)
  To: Taeung Song; +Cc: linux-kernel, taeung, Jiri Olsa, Namhyung Kim

Em Sat, Oct 14, 2017 at 12:10:12AM +0900, Taeung Song escreveu:
> perf-record had a '-l' option that mean "scale counter values"
> very long time ago, but it currently belong to perf-stat as '-c'.
> So remove it. I found this problem in the below case.

Applied,

- Arnaldo
 
>     $ perf record -e cycles -l sleep 3
>       Error: unknown switch `l
> 
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/Documentation/perf-record.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
> index 68a1ffb..5a626ef 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -8,8 +8,8 @@ perf-record - Run a command and record its profile into perf.data
>  SYNOPSIS
>  --------
>  [verse]
> -'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] <command>
> -'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] -- <command> [<options>]
> +'perf record' [-e <EVENT> | --event=EVENT] [-a] <command>
> +'perf record' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
>  
>  DESCRIPTION
>  -----------
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perf/urgent] perf record: Fix documentation for a inexistent option '-l'
  2017-10-13 15:10 [PATCH RESEND] perf record: Fix documentation for a disused option '-l' Taeung Song
  2017-10-17 12:06 ` Arnaldo Carvalho de Melo
@ 2017-10-20  7:20 ` tip-bot for Taeung Song
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Taeung Song @ 2017-10-20  7:20 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: jolsa, acme, treeze.taeung, mingo, linux-kernel, tglx, namhyung, hpa

Commit-ID:  3f50f614d61f91ad30b1947c429d1f235493a7f9
Gitweb:     https://git.kernel.org/tip/3f50f614d61f91ad30b1947c429d1f235493a7f9
Author:     Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Sat, 14 Oct 2017 00:10:12 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 17 Oct 2017 09:05:36 -0300

perf record: Fix documentation for a inexistent option '-l'

'perf record' had a '-l' option that meant "scale counter values" a very
long time ago, but it currently belongs to 'perf stat' as '-c'.  So
remove it. I found this problem in the below case.

    $ perf record -e cycles -l sleep 3
      Error: unknown switch `l

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1507907412-19813-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-record.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index e397453..63526f4 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -8,8 +8,8 @@ perf-record - Run a command and record its profile into perf.data
 SYNOPSIS
 --------
 [verse]
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] <command>
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] -- <command> [<options>]
+'perf record' [-e <EVENT> | --event=EVENT] [-a] <command>
+'perf record' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
 
 DESCRIPTION
 -----------

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-20  7:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 15:10 [PATCH RESEND] perf record: Fix documentation for a disused option '-l' Taeung Song
2017-10-17 12:06 ` Arnaldo Carvalho de Melo
2017-10-20  7:20 ` [tip:perf/urgent] perf record: Fix documentation for a inexistent " tip-bot for Taeung Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome