From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com,
Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>,
"linux-perf-use." <linux-perf-users@vger.kernel.org>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Hari Bathini <hbathini@linux.vnet.ibm.com>
Subject: Re: [PATCH] perf tools: Fix crash on buildid-list with namespace
Date: Wed, 18 Oct 2017 09:07:21 +0900 [thread overview]
Message-ID: <20171018000721.GA11621@danjae.aot.lge.com> (raw)
In-Reply-To: <20171017140555.GE4204@kernel.org>
On Tue, Oct 17, 2017 at 11:05:55AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 17, 2017 at 10:29:00PM +0900, Namhyung Kim escreveu:
> > Thomas reported that perf buildid-list gets a segfault due to NULL
> > pointer when he ran it on a data with namespace events. It was because
> > the buildid_id__mark_dso_hit_ops lacks the namespace event handler and
> > perf_too__fill_default() didn't set it.
>
> In these cases, next time I suggest you add a Fixes: tag, so that the
> stable@kernel.org guys can automatically figure out which kernels need
> this fix, in this case:
>
> Fixes: f3b3614a284d ("perf tools: Add PERF_RECORD_NAMESPACES to include namespaces related info")
Ah right, will add next time.
>
> The script I have for this even adds this CC line:
>
> Cc: Hari Bathini <hbathini@linux.vnet.ibm.com>
>
> I'm adding it,
Thanks,
Namhyung
next prev parent reply other threads:[~2017-10-18 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171017120132.GA4204@kernel.org>
2017-10-17 13:29 ` Namhyung Kim
2017-10-17 14:05 ` Arnaldo Carvalho de Melo
2017-10-18 0:07 ` Namhyung Kim [this message]
2017-10-20 7:20 ` [tip:perf/urgent] perf buildid-list: Fix crash when processing PERF_RECORD_NAMESPACE tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018000721.GA11621@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®