From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] objtool: Print top level commands on incorrect usage
Date: Wed, 18 Oct 2017 07:02:53 -0500 [thread overview]
Message-ID: <20171018120253.qbcykwl435gof3eg@treble> (raw)
In-Reply-To: <1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com>
On Sat, Oct 14, 2017 at 08:17:54PM +0530, Kamalesh Babulal wrote:
> Print top-level objtool commands, along with the error on incorrect
> command line usage. Objtool command line parser exit's with code 129,
> for incorrect usage. Convert the cmd_usage() exit code also, to maintain
> consistency across objtool.
>
> After the patch:
> $ ./objtool -j
> Unknown option: -j
>
> usage: objtool COMMAND [ARGS]
>
> Commands:
> check Perform stack metadata validation on an object file
> orc Generate in-place ORC unwind tables for an object file
>
> $ echo $?
> 129
>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> v2:
> - Changes to commit message only.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
next prev parent reply other threads:[~2017-10-18 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 14:47 Kamalesh Babulal
2017-10-18 12:02 ` Josh Poimboeuf [this message]
2017-10-18 16:23 ` [tip:core/objtool] " tip-bot for Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018120253.qbcykwl435gof3eg@treble \
--to=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®