From: David Miller <davem@davemloft.net>
To: kumba@gentoo.org
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
netdev@vger.kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ethernet/sgi: Code cleanup
Date: Thu, 19 Oct 2017 13:27:04 +0100 (WEST) [thread overview]
Message-ID: <20171019.132704.299365871401082792.davem@davemloft.net> (raw)
In-Reply-To: <53f0ad54-514a-b572-5801-7bd237055f86@gentoo.org>
From: Joshua Kinard <kumba@gentoo.org>
Date: Tue, 17 Oct 2017 13:54:30 -0400
> From: Joshua Kinard <kumba@gentoo.org>
>
> The below patch attempts to clean up the code for the in-tree driver
> for IOC3 ethernet and serial console support, primarily used by SGI
> MIPS platforms. Notable changes include:
>
> - Lots of whitespace cleanup
> - Using shorthand integer types (u16, u32, etc) where appropriate
These seem to be arbitrary, "unsigned int" is a fine value for a
hash computation.
You're also making many different kinds of changes in one patch
which makes it very difficult to review.
This driver is also for such ancient hardware, that the risk
of potentially breaking the driver far outweighs the value of
"cleaning up" the code.
next prev parent reply other threads:[~2017-10-19 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 17:54 Joshua Kinard
2017-10-19 12:27 ` David Miller [this message]
2017-10-20 2:00 ` Joshua Kinard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019.132704.299365871401082792.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®