From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
kbuild-all@01.org, Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: do not include rtmutex_common.h unconditionally
Date: Thu, 19 Oct 2017 20:15:05 +0200 [thread overview]
Message-ID: <20171019181505.gpjnwi2csdvy53vd@linutronix.de> (raw)
In-Reply-To: <20171018204259.GR3521@linux.vnet.ibm.com>
On 2017-10-18 13:42:59 [-0700], Paul E. McKenney wrote:
>
> Builds for me on x86 and 0day test robot hasn't complained, but might
> as well get it right.
So I checked you tree and there is this:
|$ git one bc2eecd7ecce40af43b6eb3d256b6076257df846
|bc2eecd7ecce ("futex: Allow for compiling out PI support")
|$ git describe bc2eecd7ecce40af43b6eb3d256b6076257df846 --contains
|v4.14-rc1~162^2~57
so this exploded on my side because I applied it on top of v3.13, you on
the other hand had it post v4.13-rc1 so it was all good.
Now, that it is possible to include that header file with and without
CONFIG_RT_MUTEX=y we could indeed move that include outside of that
ifdef. Sorry for that.
We could do that and move the two defines (rt_mutex_owner +
rt_mutex_futex_unlock) to the rtmutex_common.h like in bc2eecd7ecce.
This might look good, I don't know. If you want, I can prepare a patch
for that, we could leave it as it…
> The new commits are:
>
> a06f537e75ea ("rcu: do not include rtmutex_common.h unconditionally")
> 4a0fb5d70bb2 ("rcu: Suppress lockdep false-positive ->boost_mtx complaints")
Okay, thanks.
> Thanx, Paul
Sebastian
next prev parent reply other threads:[~2017-10-19 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201710180754.irSSdw3W%fengguang.wu@intel.com>
[not found] ` <20171018041447.GF3521@linux.vnet.ibm.com>
[not found] ` <20171018073209.7l4p3lloqiw4bm6y@linutronix.de>
2017-10-18 8:34 ` Sebastian Andrzej Siewior
2017-10-18 15:39 ` Paul E. McKenney
2017-10-18 16:16 ` Sebastian Andrzej Siewior
2017-10-18 20:42 ` Paul E. McKenney
2017-10-19 18:15 ` Sebastian Andrzej Siewior [this message]
2017-10-19 19:50 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019181505.gpjnwi2csdvy53vd@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=fengguang.wu@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®