From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: X86 ML <x86@kernel.org>, Sherry Hurwitz <sherry.hurwitz@amd.com>,
Yazen Ghannam <Yazen.Ghannam@amd.com>,
mirh@protonmail.ch, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't
Date: Sun, 22 Oct 2017 13:12:10 +0200 [thread overview]
Message-ID: <20171022111210.2bizzpjim7dyjhdz@pd.tnic> (raw)
In-Reply-To: <20171022110438.jt3erskmxrvz52us@gmail.com>
On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote:
> Any objections to me adding a printk message that we applied a fix?
>
> pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n");
>
> or so?
>
> That would also create some pressure for customers to prod manufacturers to prod
> BIOS makers to fix the erratum in a BIOS update or so.
Adding that would be purely useless because F14h is long out of
production AFAIK. Especially those earlier models.
So getting new BIOS for those is less likely than winning the lottery.
IOW, this is more or less, an after-the-fact fix for the remaining
machines out there.
Note that I didn't even use a bug flag because it would simply be a
waste.
Frankly, this fix could simply be a userspace script setting those two
MSR bits but then communicating it to people would be a nightmare, thus
the kernel fix.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-10-22 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-22 10:47 Borislav Petkov
2017-10-22 11:04 ` Ingo Molnar
2017-10-22 11:12 ` Borislav Petkov [this message]
2017-10-22 12:14 ` Ingo Molnar
2017-10-22 12:16 ` [tip:x86/urgent] x86/cpu/AMD: Apply the Erratum 688 fix when the " tip-bot for Borislav Petkov
2017-10-22 13:04 ` Peter Zijlstra
2017-10-22 14:01 ` Boris Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022111210.2bizzpjim7dyjhdz@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mirh@protonmail.ch \
--cc=sherry.hurwitz@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®