mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Ingo Molnar <mingo@redhat.com>, Roman Gushchin <guro@fb.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	kernel-team@fb.com
Subject: Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat
Date: Tue, 24 Oct 2017 10:35:04 +0200	[thread overview]
Message-ID: <20171024083504.GM3165@worktop.lehotels.local> (raw)
In-Reply-To: <20171023231827.GA8598@devbig577.frc2.facebook.com>

On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote:
> The basic cpu stat is currently shown with "cpu." prefix in
> cgroup.stat, and the same information is duplicated in cpu.stat when
> cpu controller is enabled.  This is ugly and not very scalable as we
> want to expand the coverage of stat information which is always
> available.
> 
> This patch makes cgroup core always create "cpu.stat" file and show
> the basic cpu stat there and calls the cpu controller to show the
> extra stats when enabled.  This ensures that the same information
> isn't presented in multiple places and makes future expansion of basic
> stats easier.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> Hello,
> 
> The more I think about showing cpu stat in cgroup.stat, the uglier it
> seems. 

I've not been paying much attention to this, could you elaborate on the
problems there?

> This patch flips it so that "cpu.stat" is always available
> with basic cpu stat instead.  It only changes the presentation and
> changes to the scheduler code is minimal.  Will route with the other
> cpu controller changes through cgroup/for-4.15 unless there are
> objections.

And this is -v2 only? I'm a little lost on how all that connects.

  reply	other threads:[~2017-10-24  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 23:18 Tejun Heo
2017-10-24  8:35 ` Peter Zijlstra [this message]
2017-10-24 14:59   ` Tejun Heo
2017-10-26 17:43 ` Peter Zijlstra
2017-10-26 17:57 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024083504.GM3165@worktop.lehotels.local \
    --to=peterz@infradead.org \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®