* [PATCH] spi-nor: intel-spi: Remove EXPERT dependency
@ 2017-10-24 7:40 Bin Meng
2017-10-24 9:21 ` Mika Westerberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bin Meng @ 2017-10-24 7:40 UTC (permalink / raw)
To: Mika Westerberg, Arnd Bergmann, Cyrille Pitchen, linux-mtd, linux-kernel
Cc: Stefan Roese
The idea to have the intel-spi driver dependent on EXPERT was exactly
because we did not want ordinary users playing with the device and
inadvertently overwrite their BIOSes (if it is not protected). This
seems to be superfluous hence remove it.
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
drivers/mtd/spi-nor/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
index abf453a..be7cfb9 100644
--- a/drivers/mtd/spi-nor/Kconfig
+++ b/drivers/mtd/spi-nor/Kconfig
@@ -90,7 +90,7 @@ config SPI_INTEL_SPI
tristate
config SPI_INTEL_SPI_PCI
- tristate "Intel PCH/PCU SPI flash PCI driver" if EXPERT
+ tristate "Intel PCH/PCU SPI flash PCI driver"
depends on X86 && PCI
select SPI_INTEL_SPI
help
@@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI
will be called intel-spi-pci.
config SPI_INTEL_SPI_PLATFORM
- tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
+ tristate "Intel PCH/PCU SPI flash platform driver"
depends on X86 && PCI
select SPI_INTEL_SPI
select LPC_ICH
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency
2017-10-24 7:40 [PATCH] spi-nor: intel-spi: Remove EXPERT dependency Bin Meng
@ 2017-10-24 9:21 ` Mika Westerberg
2017-10-24 10:03 ` Arnd Bergmann
2017-10-24 22:25 ` Cyrille Pitchen
2 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2017-10-24 9:21 UTC (permalink / raw)
To: Bin Meng
Cc: Arnd Bergmann, Cyrille Pitchen, linux-mtd, linux-kernel, Stefan Roese
On Tue, Oct 24, 2017 at 12:40:53AM -0700, Bin Meng wrote:
> The idea to have the intel-spi driver dependent on EXPERT was exactly
> because we did not want ordinary users playing with the device and
> inadvertently overwrite their BIOSes (if it is not protected). This
> seems to be superfluous hence remove it.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency
2017-10-24 7:40 [PATCH] spi-nor: intel-spi: Remove EXPERT dependency Bin Meng
2017-10-24 9:21 ` Mika Westerberg
@ 2017-10-24 10:03 ` Arnd Bergmann
2017-10-24 22:25 ` Cyrille Pitchen
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-10-24 10:03 UTC (permalink / raw)
To: Bin Meng
Cc: Mika Westerberg, Cyrille Pitchen, linux-mtd, linux-kernel, Stefan Roese
On Tue, Oct 24, 2017 at 9:40 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
> The idea to have the intel-spi driver dependent on EXPERT was exactly
> because we did not want ordinary users playing with the device and
> inadvertently overwrite their BIOSes (if it is not protected). This
> seems to be superfluous hence remove it.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Thansk for cleaning this up!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency
2017-10-24 7:40 [PATCH] spi-nor: intel-spi: Remove EXPERT dependency Bin Meng
2017-10-24 9:21 ` Mika Westerberg
2017-10-24 10:03 ` Arnd Bergmann
@ 2017-10-24 22:25 ` Cyrille Pitchen
2 siblings, 0 replies; 4+ messages in thread
From: Cyrille Pitchen @ 2017-10-24 22:25 UTC (permalink / raw)
To: Bin Meng, Mika Westerberg, Arnd Bergmann, linux-mtd, linux-kernel
Cc: Stefan Roese
Le 24/10/2017 à 09:40, Bin Meng a écrit :
> The idea to have the intel-spi driver dependent on EXPERT was exactly
> because we did not want ordinary users playing with the device and
> inadvertently overwrite their BIOSes (if it is not protected). This
> seems to be superfluous hence remove it.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Applied to the spi-nor/next branch of l2-mtd (reworked a little bit
since the original patch depends on "spi-nor: intel-spi: Fix Kconfig
dependency to LPC_ICH", see below).
Thanks!
> ---
>
> drivers/mtd/spi-nor/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index abf453a..be7cfb9 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -90,7 +90,7 @@ config SPI_INTEL_SPI
> tristate
>
> config SPI_INTEL_SPI_PCI
> - tristate "Intel PCH/PCU SPI flash PCI driver" if EXPERT
> + tristate "Intel PCH/PCU SPI flash PCI driver"
> depends on X86 && PCI
> select SPI_INTEL_SPI
> help
> @@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI
> will be called intel-spi-pci.
>
> config SPI_INTEL_SPI_PLATFORM
> - tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> + tristate "Intel PCH/PCU SPI flash platform driver"
> depends on X86 && PCI
removed " && PCI"
> select SPI_INTEL_SPI
> select LPC_ICH
removed "select LPC_ICH"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-24 22:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-24 7:40 [PATCH] spi-nor: intel-spi: Remove EXPERT dependency Bin Meng
2017-10-24 9:21 ` Mika Westerberg
2017-10-24 10:03 ` Arnd Bergmann
2017-10-24 22:25 ` Cyrille Pitchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome