From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: mingo@kernel.org, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pankaj.m@samsung.com,
a.sahrawat@samsung.com, Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH 1/1] arm/stacktrace: stop unwinding after an invalid address.
Date: Tue, 24 Oct 2017 12:53:38 +0100 [thread overview]
Message-ID: <20171024115338.GF20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1508845602-33508-1-git-send-email-maninder1.s@samsung.com>
On Tue, Oct 24, 2017 at 05:16:42PM +0530, Maninder Singh wrote:
> This patch stops unwinding backtrace in case of below 2 cases.
>
> (Issue observed while porting stackdepot on ARM, duplicate
> entries created in stackdepot
> reference patch for workaround in stackdepot:-
> https://lkml.org/lkml/2017/10/11/353
> ).
>
> 1. If address belongs to irq/exception code, ignore it.
> save_stack+0x40/0xec
> __set_page_owner+0x2c/0x64
> ....
> ....
> __handle_domain_irq+0x9c/0x130
> gic_handle_irq+0x40/0x80
> __irq_usr+0x4c/0x60
> 0xb6507818
> ^^^^^^^
However, we _do_ want to trace through an IRQ taken in SVC mode, but you
completely remove all that code. So, not taking this patch, sorry.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-10-24 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171024114852epcas5p199ffd8d75fc57e46d46025e12180c156@epcas5p1.samsung.com>
2017-10-24 11:46 ` Maninder Singh
2017-10-24 11:53 ` Russell King - ARM Linux [this message]
[not found] ` <CGME20171024114852epcas5p199ffd8d75fc57e46d46025e12180c156@epcms5p2>
2017-11-15 11:09 ` Maninder Singh
2017-11-15 11:26 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024115338.GF20805@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=a.sahrawat@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mingo@kernel.org \
--cc=pankaj.m@samsung.com \
--cc=v.narang@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome