mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "Stahl, Manuel" <manuel.stahl@iis-extern.fraunhofer.de>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"hjk@linutronix.de" <hjk@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sojkam1@fel.cvut.cz" <sojkam1@fel.cvut.cz>
Subject: Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers
Date: Tue, 24 Oct 2017 15:11:52 +0200	[thread overview]
Message-ID: <20171024151152.6c156c9a@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20171020125044.GA8634@kroah.com>

On Fri, 20 Oct 2017 14:50:44 +0200
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> wrote:

> On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote:
> > On Fri, 6 Oct 2017 13:50:44 +0000
> > "Stahl, Manuel" <manuel.stahl@iis-extern.fraunhofer.de> wrote:
> >   
> > > MSI(X) interrupts are not shared between devices. So when available
> > > those should be preferred over legacy interrupts.
> > > 
> > > Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
> > > ---
> > >  drivers/uio/uio_pci_dmem_genirq.c | 27 ++++++++++++++++++++-------
> > >  drivers/uio/uio_pci_generic.c     | 24 ++++++++++++++++++------
> > >  2 files changed, 38 insertions(+), 13 deletions(-)  
> > 
> > The last time I tried to do MSI-X with pci-generic it got rejected
> > by the maintainer.  
> 
> Hm, yeah, this would break users today that do not have msi-x, right?
> 
> Not good, Manuel, how well did you test this?
> 
> thanks,
> 
> greg k-h

Look at https://patchwork.kernel.org/patch/7303021/

The objection was more that UIO developers did not like that
UIO was (already) being used for DMA without IOMMU, and MSI-x has DMA because
of vector table.

  parent reply	other threads:[~2017-10-24 13:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 13:31 [PATCH 1/2 v3] Add new uio device for PCI with dynamic memory allocation Stahl, Manuel
2017-10-06 13:33 ` [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers Stahl, Manuel
2017-10-06 13:45   ` gregkh
2017-10-06 13:50     ` Stahl, Manuel
2017-10-06 14:57       ` Stephen Hemminger
2017-10-20 12:50         ` gregkh
2017-10-20 12:58           ` Stahl, Manuel
2020-03-04 15:19             ` Stahl, Manuel
2020-03-04 15:44               ` gregkh
2017-10-24 13:11           ` Stephen Hemminger [this message]
2020-04-16 16:38 ` [PATCH v4] Add new uio device for PCI with dynamic memory allocation Manuel Stahl
2020-04-28 13:54   ` gregkh @ linuxfoundation . org
2020-04-28 15:47     ` Stahl, Manuel
2020-04-28 15:58       ` gregkh
2020-04-29  7:51     ` Stahl, Manuel
2020-04-29  9:41       ` gregkh
2020-04-29 13:53         ` Stahl, Manuel
2023-05-18  4:48           ` Hongren Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024151152.6c156c9a@shemminger-XPS-13-9360 \
    --to=stephen@networkplumber.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.stahl@iis-extern.fraunhofer.de \
    --cc=sojkam1@fel.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®