From: Rob Herring <robh@kernel.org>
To: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute
Date: Wed, 25 Oct 2017 09:53:37 -0500 [thread overview]
Message-ID: <20171025145337.kubcbkxrhbsy6o4a@rob-hp-laptop> (raw)
In-Reply-To: <1508383560-15567-1-git-send-email-raveendra.padasalagi@broadcom.com>
On Thu, Oct 19, 2017 at 08:55:59AM +0530, Raveendra Padasalagi wrote:
> Add documentation on optional dt attribute "debounce-timeout-ms"
> in extcon node to capture user specified timeout value for id
> and vbus gpio detection.
>
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
>
> Changes in v2:
> Rename debounce-timeout-ms to input-debounce
>
> Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
> 1 file changed, 3 insertions(+)
Sorry, but extcon bindings should be scrapped IMO and I don't want to
see additions. "extcon" is a Linuxism and is the first clue.
What's needed is a full USB connector binding, not just some incomplete
handling of ID and Vbus pins. There's some work happening on that[1].
Rob
[1] https://www.spinics.net/lists/linux-usb/msg161106.html
next prev parent reply other threads:[~2017-10-25 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171019032612epcas5p40f27200408a554d4942802b986503636@epcas5p4.samsung.com>
2017-10-19 3:25 ` Raveendra Padasalagi
2017-10-19 3:26 ` [PATCH v2 2/2] " Raveendra Padasalagi
2017-10-19 4:59 ` Chanwoo Choi
2017-10-19 5:22 ` Chanwoo Choi
2017-10-19 9:33 ` Raveendra Padasalagi
2017-10-19 4:47 ` [PATCH v2 1/2] Documentation: dt: " Chanwoo Choi
2017-10-19 4:54 ` Chanwoo Choi
2017-10-25 14:53 ` Rob Herring [this message]
2017-10-26 0:45 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025145337.kubcbkxrhbsy6o4a@rob-hp-laptop \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=raveendra.padasalagi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®